Re: [PATCH net-next] ax88796c: fix fetching error stats from percpu containers
From: Lukasz Stelmach <l.stelmach@samsung.com>
Date: 2021-10-25 19:58:26
It was <2021-10-23 sob 12:19>, when Alexander Lobakin wrote:
rx_dropped, tx_dropped, rx_frame_errors and rx_crc_errors are being wrongly fetched from the target container rather than source percpu ones. No idea if that goes from the vendor driver or was brainoed during the refactoring, but fix it either way.
It may be the latter. Thank you for fixing.
Fixes: a97c69ba4f30e ("net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver")
Signed-off-by: Alexander Lobakin <redacted>
---
drivers/net/ethernet/asix/ax88796c_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>
quoted hunk
diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethernet/asix/ax88796c_main.c index cfc597f72e3d..91fa0499ea6a 100644 --- a/drivers/net/ethernet/asix/ax88796c_main.c +++ b/drivers/net/ethernet/asix/ax88796c_main.c@@ -672,10 +672,10 @@ static void ax88796c_get_stats64(struct net_device *ndev, stats->tx_packets += tx_packets; stats->tx_bytes += tx_bytes; - rx_dropped += stats->rx_dropped; - tx_dropped += stats->tx_dropped; - rx_frame_errors += stats->rx_frame_errors; - rx_crc_errors += stats->rx_crc_errors; + rx_dropped += s->rx_dropped; + tx_dropped += s->tx_dropped; + rx_frame_errors += s->rx_frame_errors; + rx_crc_errors += s->rx_crc_errors; } stats->rx_dropped = rx_dropped; --2.33.1
-- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics