[PATCH] net: liquidio: Make use of the helper macro kthread_run()

Subsystems: cavium liquidio network driver, networking drivers, the rest

STALE1758d LANDED

Landed in mainline as 47b068247aa7 on 2021-10-22.

2 messages, 2 authors, 2021-10-22 · open the first message on its own page

[PATCH] net: liquidio: Make use of the helper macro kthread_run()

From: Cai Huoqing <hidden>
Date: 2021-10-21 08:42:06

Repalce kthread_create/wake_up_process() with kthread_run()
to simplify the code.

Signed-off-by: Cai Huoqing <redacted>
---
 drivers/net/ethernet/cavium/liquidio/lio_main.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c
index 1daf63e437ce..12eee2bc7f5c 100644
--- a/drivers/net/ethernet/cavium/liquidio/lio_main.c
+++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c
@@ -892,12 +892,11 @@ liquidio_probe(struct pci_dev *pdev, const struct pci_device_id __maybe_unused *
 			bus = pdev->bus->number;
 			device = PCI_SLOT(pdev->devfn);
 			function = PCI_FUNC(pdev->devfn);
-			oct_dev->watchdog_task = kthread_create(
-			    liquidio_watchdog, oct_dev,
-			    "liowd/%02hhx:%02hhx.%hhx", bus, device, function);
-			if (!IS_ERR(oct_dev->watchdog_task)) {
-				wake_up_process(oct_dev->watchdog_task);
-			} else {
+			oct_dev->watchdog_task = kthread_run(liquidio_watchdog,
+							     oct_dev,
+							     "liowd/%02hhx:%02hhx.%hhx",
+							     bus, device, function);
+			if (IS_ERR(oct_dev->watchdog_task)) {
 				oct_dev->watchdog_task = NULL;
 				dev_err(&oct_dev->pci_dev->dev,
 					"failed to create kernel_thread\n");
-- 
2.25.1

Re: [PATCH] net: liquidio: Make use of the helper macro kthread_run()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-22 18:20:10

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski [off-list ref]:

On Thu, 21 Oct 2021 16:41:58 +0800 you wrote:
Repalce kthread_create/wake_up_process() with kthread_run()
to simplify the code.

Signed-off-by: Cai Huoqing <redacted>
---
 drivers/net/ethernet/cavium/liquidio/lio_main.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
Here is the summary with links:
  - net: liquidio: Make use of the helper macro kthread_run()
    https://git.kernel.org/netdev/net-next/c/47b068247aa7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help