Re: [PATCH] rtw89: fix error function parameter

Pkshih [off-list ref] writes:

quoted

-----Original Message-----
From: kvalo=codeaurora.org@mg.codeaurora.org
[off-list ref] On Behalf Of Kalle
Valo
Sent: Wednesday, October 20, 2021 4:50 PM
To: cgel.zte@gmail.com
Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
[off-list ref]; lv.ruyi@zte.com.cn;
linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
linux-kernel@vger.kernel.org; Zeal Robot
[off-list ref]
Subject: Re: [PATCH] rtw89: fix error function parameter

cgel.zte@gmail.com wrote:

quoted

From: Lv Ruyi <redacted>

This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING  possible condition with no effect (if == else)

Reported-by: Zeal Robot <redacted>
Signed-off-by: Lv Ruyi <redacted>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Failed to apply, please rebase on top of wireless-drivers-next.

error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: rtw89: fix error function parameter
Using index info to reconstruct a base tree...
Patch failed at 0001 rtw89: fix error function parameter

Patch set to Changes Requested.

I think this is because the patch is translated into spaces instead of tabs, 
in this and following statements.
"                if (is_2g)"

Ah, I did wonder why it failed as I didn't see any similar patches. We
have an item about this in the wiki:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-----Original Message-----
From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
Valo
Sent: Wednesday, October 20, 2021 6:04 PM
To: Pkshih <pkshih@realtek.com>
Cc: cgel.zte@gmail.com; davem@davemloft.net; kuba@kernel.org; lv.ruyi@zte.com.cn;
linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
[off-list ref]
Subject: Re: [PATCH] rtw89: fix error function parameter

Pkshih [off-list ref] writes:

quoted

quoted

-----Original Message-----
From: kvalo=codeaurora.org@mg.codeaurora.org
[off-list ref] On Behalf Of Kalle
Valo
Sent: Wednesday, October 20, 2021 4:50 PM
To: cgel.zte@gmail.com
Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
[off-list ref]; lv.ruyi@zte.com.cn;
linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
linux-kernel@vger.kernel.org; Zeal Robot
[off-list ref]
Subject: Re: [PATCH] rtw89: fix error function parameter

cgel.zte@gmail.com wrote:

quoted

From: Lv Ruyi <redacted>

This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING  possible condition with no effect (if == else)

Reported-by: Zeal Robot <redacted>
Signed-off-by: Lv Ruyi <redacted>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Failed to apply, please rebase on top of wireless-drivers-next.

error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: rtw89: fix error function parameter
Using index info to reconstruct a base tree...
Patch failed at 0001 rtw89: fix error function parameter

Patch set to Changes Requested.

I think this is because the patch is translated into spaces instead of tabs,
in this and following statements.
"                if (is_2g)"

Ah, I did wonder why it failed as I didn't see any similar patches. We
have an item about this in the wiki:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues

I don't know why neither.

I check the mail header of this patch, the mailer is
"X-Mailer: git-send-email 2.25.1". It should work properly.

Lv Ruyi, could you help to check what happens?

--
Ping-Ke

On Thu, Oct 21, 2021 at 01:34:25AM +0000, Pkshih wrote:

quoted

-----Original Message-----
From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
Valo
Sent: Wednesday, October 20, 2021 6:04 PM
To: Pkshih <pkshih@realtek.com>
Cc: cgel.zte@gmail.com; davem@davemloft.net; kuba@kernel.org; lv.ruyi@zte.com.cn;
linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
[off-list ref]
Subject: Re: [PATCH] rtw89: fix error function parameter

Pkshih [off-list ref] writes:

quoted

quoted

-----Original Message-----
From: kvalo=codeaurora.org@mg.codeaurora.org
[off-list ref] On Behalf Of Kalle
Valo
Sent: Wednesday, October 20, 2021 4:50 PM
To: cgel.zte@gmail.com
Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
[off-list ref]; lv.ruyi@zte.com.cn;
linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
linux-kernel@vger.kernel.org; Zeal Robot
[off-list ref]
Subject: Re: [PATCH] rtw89: fix error function parameter

cgel.zte@gmail.com wrote:

quoted

From: Lv Ruyi <redacted>

This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING  possible condition with no effect (if == else)

Reported-by: Zeal Robot <redacted>
Signed-off-by: Lv Ruyi <redacted>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Failed to apply, please rebase on top of wireless-drivers-next.

error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: rtw89: fix error function parameter
Using index info to reconstruct a base tree...
Patch failed at 0001 rtw89: fix error function parameter

Patch set to Changes Requested.

I think this is because the patch is translated into spaces instead of tabs,
in this and following statements.
"                if (is_2g)"

Ah, I did wonder why it failed as I didn't see any similar patches. We
have an item about this in the wiki:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues

I don't know why neither.

I check the mail header of this patch, the mailer is
"X-Mailer: git-send-email 2.25.1". It should work properly.

Lv Ruyi, could you help to check what happens?

--
Ping-Ke

Thanks for Ping-Ke's suggestion,you are right.The previous patch
is translated into spaces instead of tabs,and I will submitt a
new correct one.

From: Lv Ruyi <redacted>

This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING  possible condition with no effect (if == else)

Reported-by: Zeal Robot <redacted>
Signed-off-by: Lv Ruyi <redacted>
---
 drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
index b1b87f0aadbb..5c6ffca3a324 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c

@@ -757,7 +757,7 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
 		else
 			rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
 					      B_P1_MODE_SEL,
-					      1, phy_idx);
+					      0, phy_idx);
 		/* SCO compensate FC setting */
 		sco_comp = rtw8852a_sco_mapping(central_ch);
 		rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,

-- 
2.25.1

-----Original Message-----
From: cgel.zte@gmail.com <redacted>
Sent: Thursday, October 21, 2021 12:21 PM
To: Pkshih <pkshih@realtek.com>
Cc: kvalo@codeaurora.org; davem@davemloft.net; kuba@kernel.org; linux-wireless@vger.kernel.org;
netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Lv Ruyi [off-list ref]; Zeal Robot
[off-list ref]
Subject: [PATCH V2] rtw89: fix error function parameter

From: Lv Ruyi <redacted>

This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING  possible condition with no effect (if == else)

Reported-by: Zeal Robot <redacted>
Signed-off-by: Lv Ruyi <redacted>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

I think you can say something about the changes of v2 followed by '---', like

---
v2: fix tabs are converted to spaces

  ^^^^^^
I have confirmed this is a tab.

 			rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
 					      B_P1_MODE_SEL,
-					      1, phy_idx);
+					      0, phy_idx);
 		/* SCO compensate FC setting */
 		sco_comp = rtw8852a_sco_mapping(central_ch);
 		rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
--
2.25.1

cgel.zte@gmail.com wrote:

From: Lv Ruyi <redacted>

This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING  possible condition with no effect (if == else)

Reported-by: Zeal Robot <redacted>
Signed-off-by: Lv Ruyi <redacted>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-drivers-next.git, thanks.

dea857700a75 rtw89: fix error function parameter

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211021042035.1042463-1-lv.ruyi@zte.com.cn/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches