# RE: \[PATCH\] rtw89: fix error function parameter

- From: Pkshih \<pkshih@realtek.com\>
- Date: 2021-10-20 09:46:34 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/10/1548060
- Thread: https://ratatoskr.run/linux-wireless/2021/10/1546474/t.md

```text

> -----Original Message-----
> From: <redacted> <redacted> On Behalf Of Kalle
> Valo
> Sent: Wednesday, October 20, 2021 4:50 PM
> To: <redacted>
> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih <pkshih@realtek.com>; <redacted>;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> [ref]
> Subject: Re: [PATCH] rtw89: fix error function parameter
> 
> cgel.zte@gmail.com wrote:
> 
> > From: Lv Ruyi <redacted>
> >
> > This patch fixes the following Coccinelle warning:
> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> > WARNING  possible condition with no effect (if == else)
> >
> > Reported-by: Zeal Robot <redacted>
> > Signed-off-by: Lv Ruyi <redacted>
> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> Failed to apply, please rebase on top of wireless-drivers-next.
> 
> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> error: Did you hand edit your patch?
> It does not apply to blobs recorded in its index.
> hint: Use 'git am --show-current-patch' to see the failed patch
> Applying: rtw89: fix error function parameter
> Using index info to reconstruct a base tree...
> Patch failed at 0001 rtw89: fix error function parameter
> 
> Patch set to Changes Requested.
> 

I think this is because the patch is translated into spaces instead of tabs, 
in this and following statements.
"                if (is_2g)"

--
Ping-Ke


```