[PATCH linux-next] ethernet: Remove redundant statement

Subsystems: broadcom tg3 gigabit ethernet driver, networking drivers, the rest

STALE1762d

2 messages, 2 authors, 2021-10-19 · open the first message on its own page

[PATCH linux-next] ethernet: Remove redundant statement

From: luo penghao <hidden>
Date: 2021-10-18 08:55:36

The variable will be assigned again later in the if condition,
there is no meaning there.

drivers/net/ethernet/broadcom/tg3.c:5750:2 warning:

Value stored to 'current_link_up' is never read.

Reported-by: Zeal Robot <redacted>
Signed-off-by: luo penghao <redacted>
---
 drivers/net/ethernet/broadcom/tg3.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index e9518b9..b1328c5 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -5747,7 +5747,6 @@ static int tg3_setup_fiber_phy(struct tg3 *tp, bool force_reset)
 	tw32_f(MAC_EVENT, MAC_EVENT_LNKSTATE_CHANGED);
 	udelay(40);
 
-	current_link_up = false;
 	tp->link_config.rmt_adv = 0;
 	mac_status = tr32(MAC_STATUS);
 
-- 
2.15.2

Re: [PATCH linux-next] ethernet: Remove redundant statement

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-19 12:20:13

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller [off-list ref]:

On Mon, 18 Oct 2021 08:55:13 +0000 you wrote:
The variable will be assigned again later in the if condition,
there is no meaning there.

drivers/net/ethernet/broadcom/tg3.c:5750:2 warning:

Value stored to 'current_link_up' is never read.

[...]
Here is the summary with links:
  - [linux-next] ethernet: Remove redundant statement
    https://git.kernel.org/netdev/net-next/c/3c71e0c9ab4f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help