[PATCH net] net: dsa: lantiq_gswip: fix register definition

Subsystems: networking drivers, networking [dsa], the rest

STALE1780d

3 messages, 3 authors, 2021-10-18 · open the first message on its own page

[PATCH net] net: dsa: lantiq_gswip: fix register definition

From: Aleksander Jan Bajkowski <hidden>
Date: 2021-10-15 22:10:33

I compared the register definitions with the D-Link DWR-966
GPL sources and found that the PUAFD field definition was
incorrect. This definition is unused and causes no issues.

Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <redacted>
---
 drivers/net/dsa/lantiq_gswip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 3ff4b7e177f3..dbd4486a173f 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -230,7 +230,7 @@
 #define GSWIP_SDMA_PCTRLp(p)		(0xBC0 + ((p) * 0x6))
 #define  GSWIP_SDMA_PCTRL_EN		BIT(0)	/* SDMA Port Enable */
 #define  GSWIP_SDMA_PCTRL_FCEN		BIT(1)	/* Flow Control Enable */
-#define  GSWIP_SDMA_PCTRL_PAUFWD	BIT(1)	/* Pause Frame Forwarding */
+#define  GSWIP_SDMA_PCTRL_PAUFWD	BIT(3)	/* Pause Frame Forwarding */
 
 #define GSWIP_TABLE_ACTIVE_VLAN		0x01
 #define GSWIP_TABLE_VLAN_MAPPING	0x02
-- 
2.30.2

Re: [PATCH net] net: dsa: lantiq_gswip: fix register definition

From: Hauke Mehrtens <hauke@hauke-m.de>
Date: 2021-10-16 11:58:13

On 10/16/21 12:10 AM, Aleksander Jan Bajkowski wrote:
I compared the register definitions with the D-Link DWR-966
GPL sources and found that the PUAFD field definition was
incorrect. This definition is unused and causes no issues.

Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <redacted>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>

Thanks for finding this problem.
quoted hunk
---
  drivers/net/dsa/lantiq_gswip.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 3ff4b7e177f3..dbd4486a173f 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -230,7 +230,7 @@
  #define GSWIP_SDMA_PCTRLp(p)		(0xBC0 + ((p) * 0x6))
  #define  GSWIP_SDMA_PCTRL_EN		BIT(0)	/* SDMA Port Enable */
  #define  GSWIP_SDMA_PCTRL_FCEN		BIT(1)	/* Flow Control Enable */
-#define  GSWIP_SDMA_PCTRL_PAUFWD	BIT(1)	/* Pause Frame Forwarding */
+#define  GSWIP_SDMA_PCTRL_PAUFWD	BIT(3)	/* Pause Frame Forwarding */
  
  #define GSWIP_TABLE_ACTIVE_VLAN		0x01
  #define GSWIP_TABLE_VLAN_MAPPING	0x02

Re: [PATCH net] net: dsa: lantiq_gswip: fix register definition

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-10-18 12:40:09

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller [off-list ref]:

On Sat, 16 Oct 2021 00:10:20 +0200 you wrote:
I compared the register definitions with the D-Link DWR-966
GPL sources and found that the PUAFD field definition was
incorrect. This definition is unused and causes no issues.

Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <redacted>

[...]
Here is the summary with links:
  - [net] net: dsa: lantiq_gswip: fix register definition
    https://git.kernel.org/netdev/net/c/66d262804a22

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help