[PATCH] selftests: bpf: Remove dumplicated include in cgroup_helpers

Subsystems: bpf [general] (safe dynamic programs and tools), bpf [selftests] (test runners & infrastructure), kernel selftest framework, the rest

STALE1770d

2 messages, 2 authors, 2021-10-11 · open the first message on its own page

[PATCH] selftests: bpf: Remove dumplicated include in cgroup_helpers

From: Wan Jiabing <hidden>
Date: 2021-10-11 11:23:44

Fix following checkincludes.pl warning:
./tools/testing/selftests/bpf/cgroup_helpers.c
12	#include <unistd.h>
    14	#include <unistd.h>

Signed-off-by: Wan Jiabing <redacted>
---
 tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
index 8fcd44841bb2..9d59c3990ca8 100644
--- a/tools/testing/selftests/bpf/cgroup_helpers.c
+++ b/tools/testing/selftests/bpf/cgroup_helpers.c
@@ -11,7 +11,6 @@
 #include <fcntl.h>
 #include <unistd.h>
 #include <ftw.h>
-#include <unistd.h>
 
 #include "cgroup_helpers.h"
 
-- 
2.30.2

Re: [PATCH] selftests: bpf: Remove dumplicated include in cgroup_helpers

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2021-10-11 14:30:22

On 10/11/21 1:19 PM, Wan Jiabing wrote:
Fix following checkincludes.pl warning:
./tools/testing/selftests/bpf/cgroup_helpers.c
12	#include <unistd.h>
     14	#include <unistd.h>
What does the 12 vs 14 mean here? Please provide a proper commit description, e.g. if
you used checkincludes.pl, maybe include the full command invocation and the relevant
output, so that this is more obvious and in a better shape. Thanks!
quoted hunk
Signed-off-by: Wan Jiabing <redacted>
---
  tools/testing/selftests/bpf/cgroup_helpers.c | 1 -
  1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/cgroup_helpers.c b/tools/testing/selftests/bpf/cgroup_helpers.c
index 8fcd44841bb2..9d59c3990ca8 100644
--- a/tools/testing/selftests/bpf/cgroup_helpers.c
+++ b/tools/testing/selftests/bpf/cgroup_helpers.c
@@ -11,7 +11,6 @@
  #include <fcntl.h>
  #include <unistd.h>
  #include <ftw.h>
-#include <unistd.h>
  
  #include "cgroup_helpers.h"
  

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help