[PATCH] mt7601u: Remove redundant initialization of variable ret

Subsystems: mediatek mt7601u wireless lan driver, the rest

STALE1768d LANDED

Landed in mainline as 3e4beec5e679 on 2021-10-13.

3 messages, 3 authors, 2021-10-13 · open the first message on its own page

[PATCH] mt7601u: Remove redundant initialization of variable ret

From: Colin King <hidden>
Date: 2021-10-07 23:42:00

From: Colin Ian King <redacted>

The variable ret is being initialized with a value that is never read,
it is assigned later on with a different value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/wireless/mediatek/mt7601u/dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt7601u/dma.c b/drivers/net/wireless/mediatek/mt7601u/dma.c
index ed78d2cb35e3..457147394edc 100644
--- a/drivers/net/wireless/mediatek/mt7601u/dma.c
+++ b/drivers/net/wireless/mediatek/mt7601u/dma.c
@@ -515,7 +515,7 @@ static int mt7601u_alloc_tx(struct mt7601u_dev *dev)
 
 int mt7601u_dma_init(struct mt7601u_dev *dev)
 {
-	int ret = -ENOMEM;
+	int ret;
 
 	tasklet_setup(&dev->tx_tasklet, mt7601u_tx_tasklet);
 	tasklet_setup(&dev->rx_tasklet, mt7601u_rx_tasklet);
-- 
2.32.0

Re: [PATCH] mt7601u: Remove redundant initialization of variable ret

From: Jakub Kicinski <hidden>
Date: 2021-10-08 02:21:33

On Fri,  8 Oct 2021 00:41:53 +0100 Colin King wrote:
From: Colin Ian King <redacted>

The variable ret is being initialized with a value that is never read,
it is assigned later on with a different value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
Acked-by: Jakub Kicinski <redacted>

Re: [PATCH] mt7601u: Remove redundant initialization of variable ret

From: Kalle Valo <hidden>
Date: 2021-10-13 06:21:46

Colin King [off-list ref] wrote:
From: Colin Ian King <redacted>

The variable ret is being initialized with a value that is never read,
it is assigned later on with a different value. The initialization is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
Acked-by: Jakub Kicinski <redacted>
Patch applied to wireless-drivers-next.git, thanks.

3e4beec5e679 mt7601u: Remove redundant initialization of variable ret

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20211007234153.31222-1-colin.king@canonical.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help