[PATCH net] net: mana: Fix error handling in mana_create_rxq()
Subsystems:
hyper-v/azure core and drivers, networking drivers, the rest
STALE1795d
3 messages,
2 authors,
2021-10-08 · open the first message on its own page
Fix error handling in mana_create_rxq() when
cq->gdma_id >= gc->max_num_cqs.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
---
drivers/net/ethernet/microsoft/mana/mana_en.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 9a871192ca96..d65697c239c8 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -1477,8 +1477,10 @@ static struct mana_rxq *mana_create_rxq(struct mana_port_context *apc,
if (err)
goto out;
- if (cq->gdma_id >= gc->max_num_cqs)
+ if (WARN_ON(cq->gdma_id >= gc->max_num_cqs)) {
+ err = -EINVAL;
goto out;
+ }
gc->cq_table[cq->gdma_id] = cq->gdma_cq;
--
2.25.1
On Thu, 7 Oct 2021 15:45:33 -0700 Haiyang Zhang wrote:
Fix error handling in mana_create_rxq() when
cq->gdma_id >= gc->max_num_cqs.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")
-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, October 7, 2021 10:28 PM
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: linux-hyperv@vger.kernel.org; netdev@vger.kernel.org; KY Srinivasan
[off-list ref]; Stephen Hemminger [off-list ref]; Paul
Rosswurm [off-list ref]; Shachar Raindel
[off-list ref]; olaf@aepfle.de; vkuznets [off-list ref];
davem@davemloft.net; linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: mana: Fix error handling in
mana_create_rxq()
On Thu, 7 Oct 2021 15:45:33 -0700 Haiyang Zhang wrote:
quoted
Fix error handling in mana_create_rxq() when
cq->gdma_id >= gc->max_num_cqs.
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure
Network Adapter (MANA)")
I will add "Fixes" line.
Thanks,
- Haiyang