# \[PATCH AUTOSEL 5.14 26/40\] mac80211: check return value of rhashtable\_init

- Subsystems: MAC80211, THE REST
- Maintainers: Johannes Berg, Linus Torvalds
- List: netdev
- 1 message, 1 author
- Page: https://ratatoskr.run/netdev/2021/10/1531513/t

## \[PATCH AUTOSEL 5.14 26/40\] mac80211: check return value of rhashtable\_init

- From: Sasha Levin \<sashal@kernel.org\>
- Date: 2021-10-05 13:52:21 
- Message: https://ratatoskr.run/netdev/2021/10/1531513.md

```text
From: MichelleJin <redacted>

[ Upstream commit 111461d573741c17eafad029ac93474fa9adcce0 ]

When rhashtable_init() fails, it returns -EINVAL.
However, since error return value of rhashtable_init is not checked,
it can cause use of uninitialized pointers.
So, fix unhandled errors of rhashtable_init.

Signed-off-by: MichelleJin <redacted>
Link: https://lore.kernel.org/r/20210927033457.1020967-4-shjy180909@gmail.com
Signed-off-by: Johannes Berg <redacted>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 net/mac80211/mesh_pathtbl.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c
index efbefcbac3ac..7cab1cf09bf1 100644
--- a/net/mac80211/mesh_pathtbl.c
+++ b/net/mac80211/mesh_pathtbl.c
@@ -60,7 +60,10 @@ static struct mesh_table *mesh_table_alloc(void)
 	atomic_set(&newtbl->entries,  0);
 	spin_lock_init(&newtbl->gates_lock);
 	spin_lock_init(&newtbl->walk_lock);
-	rhashtable_init(&newtbl->rhead, &mesh_rht_params);
+	if (rhashtable_init(&newtbl->rhead, &mesh_rht_params)) {
+		kfree(newtbl);
+		return NULL;
+	}
 
 	return newtbl;
 }
-- 
2.33.0

```