# Re: \[RFC net-next PATCH 09/16\] net: macb: Move most of mac\_prepare to mac\_config

- From: Sean Anderson \<hidden\>
- Date: 2021-10-04 23:10:02 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/10/1530659
- Thread: https://ratatoskr.run/netdev/2021/10/1530490/t.md

```text


On 10/4/21 7:05 PM, Russell King (Oracle) wrote:
> On Mon, Oct 04, 2021 at 03:15:20PM -0400, Sean Anderson wrote:
>> mac_prepare is called every time the interface is changed, so we can do
>> all of our configuration there, instead of in mac_config. This will be
>> useful for the next patch where we will set the PCS bit based on whether
>> we are using our internal PCS. No functional change intended.
>
> The subject line appears to be the reverse of what you're actually
> doing.
>

So it does.

--Sean
```
