# Re: \[RFC net-next PATCH 08/16\] net: macb: Clean up macb\_validate

- From: Sean Anderson \<hidden\>
- Date: 2021-10-04 23:09:30 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/10/1530658
- Thread: https://ratatoskr.run/netdev/2021/10/1530490/t.md

```text


On 10/4/21 7:04 PM, Russell King (Oracle) wrote:
> On Mon, Oct 04, 2021 at 03:15:19PM -0400, Sean Anderson wrote:
>> As the number of interfaces grows, the number of if statements grows
>> ever more unweildy. Clean everything up a bit by using a switch
>> statement. No functional change intended.
>
> This doesn't look right to me.
>
>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
>> index e2730b3e1a57..18afa544b623 100644
>> --- a/drivers/net/ethernet/cadence/macb_main.c
>> +++ b/drivers/net/ethernet/cadence/macb_main.c
>> @@ -510,32 +510,55 @@ static void macb_validate(struct phylink_config *config,
>>  			  unsigned long *supported,
>>  			  struct phylink_link_state *state)
>>  {
>> +	bool one = state->interface == PHY_INTERFACE_MODE_NA;
>
> Shouldn't this be != ?
>
> Since PHY_INTERFACE_MODE_NA is supposed to return all capabilities.
>

Ah, yes it should.

--Sean
```
