Increase the rx ring size (LAN743X_RX_RING_SIZE) to improve rx performance on some platforms.
Tested on x86 PC with EVB-LAN7430.
The iperf3.7 TCPIP improved from 881 Mbps to 922 Mbps, and UDP improved from 817 Mbps to 936 Mbps.
Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
Signed-off-by: Yuiko Oshino <redacted>
---
drivers/net/ethernet/microchip/lan743x_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Jakub Kicinski <kuba@kernel.org> Date: 2021-10-28 15:13:47
On Thu, 28 Oct 2021 11:03:15 -0400 Yuiko Oshino wrote:
Increase the rx ring size (LAN743X_RX_RING_SIZE) to improve rx performance on some platforms.
Tested on x86 PC with EVB-LAN7430.
The iperf3.7 TCPIP improved from 881 Mbps to 922 Mbps, and UDP improved from 817 Mbps to 936 Mbps.
Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
Signed-off-by: Yuiko Oshino <redacted>
You seem to be posting performance optimizations as fixes.
800Mbps is not "broken" for a 1G interface. Please remove
the Fixes tag and re-post this with [PATCH net-next].
Thank you!
-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Thursday, October 28, 2021 11:14 AM
To: Yuiko Oshino - C18177 <redacted>
Cc: davem@davemloft.net; netdev@vger.kernel.org; Bryan Whitehead - C21958
[off-list ref]; UNGLinuxDriver
[off-list ref]
Subject: Re: [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring size
to improve rx performance
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
On Thu, 28 Oct 2021 11:03:15 -0400 Yuiko Oshino wrote:
quoted
Increase the rx ring size (LAN743X_RX_RING_SIZE) to improve rx performance
on some platforms.
quoted
Tested on x86 PC with EVB-LAN7430.
The iperf3.7 TCPIP improved from 881 Mbps to 922 Mbps, and UDP improved
from 817 Mbps to 936 Mbps.
quoted
Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x
driver")
Signed-off-by: Yuiko Oshino <redacted>
You seem to be posting performance optimizations as fixes.
800Mbps is not "broken" for a 1G interface. Please remove the Fixes tag and re-
post this with [PATCH net-next].
Thank you!
Hi Jakub,
no problem.
Thank you for your comment.
Yuiko
From: Andrew Lunn <andrew@lunn.ch> Date: 2021-10-28 16:03:21
On Thu, Oct 28, 2021 at 11:03:15AM -0400, Yuiko Oshino wrote:
quoted hunk
Increase the rx ring size (LAN743X_RX_RING_SIZE) to improve rx performance on some platforms.
Tested on x86 PC with EVB-LAN7430.
The iperf3.7 TCPIP improved from 881 Mbps to 922 Mbps, and UDP improved from 817 Mbps to 936 Mbps.
Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
Signed-off-by: Yuiko Oshino <redacted>
---
drivers/net/ethernet/microchip/lan743x_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
-----Original Message-----
From: Andrew Lunn <andrew@lunn.ch>
Sent: Thursday, October 28, 2021 12:03 PM
To: Yuiko Oshino - C18177 <redacted>
Cc: davem@davemloft.net; netdev@vger.kernel.org; Bryan Whitehead - C21958
[off-list ref]; UNGLinuxDriver
[off-list ref]
Subject: Re: [PATCH net] net: ethernet: microchip: lan743x: Increase rx ring size
to improve rx performance
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
On Thu, Oct 28, 2021 at 11:03:15AM -0400, Yuiko Oshino wrote:
quoted
Increase the rx ring size (LAN743X_RX_RING_SIZE) to improve rx performance
on some platforms.
quoted
Tested on x86 PC with EVB-LAN7430.
The iperf3.7 TCPIP improved from 881 Mbps to 922 Mbps, and UDP improved
from 817 Mbps to 936 Mbps.
quoted
Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
Signed-off-by: Yuiko Oshino <redacted>
---
drivers/net/ethernet/microchip/lan743x_main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
65 is interesting. 2^N + 1. So there might be a reason for this?
The original developer wanted to give the hardware a power of 2 usable (which is the ring size -1) number of descriptors, but that is not required by the hardware so for this update we decided to take it back to "rounder" power of 2 memory request from the OS.