# Re: \[PATCH V3 net-next 4/6\] ethtool: extend ringparam setting uAPI with rx\_buf\_len

- From: huangguangbin (A) \<hidden\>
- Date: 2021-10-14 06:35:51 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/10/11213382
- Thread: https://ratatoskr.run/netdev/2021/10/11213197/t.md

```text


On 2021/10/13 2:26, Jakub Kicinski wrote:
> On Tue, 12 Oct 2021 21:41:25 +0800 Guangbin Huang wrote:
>> @@ -80,7 +83,10 @@ static int rings_fill_reply(struct sk_buff *skb,
>>   	     (nla_put_u32(skb, ETHTOOL_A_RINGS_TX_MAX,
>>   			  ringparam->tx_max_pending) ||
>>   	      nla_put_u32(skb, ETHTOOL_A_RINGS_TX,
>> -			  ringparam->tx_pending))))
>> +			  ringparam->tx_pending)))  ||
>> +	    (ringparam_ext->rx_buf_len &&
>> +	     (nla_put_u32(skb, ETHTOOL_A_RINGS_RX_BUF_LEN,
>> +			  ringparam_ext->rx_buf_len))))
>>   		return -EMSGSIZE;
>
> I think that this chunk belongs in the previous patch.
> .
>
Ok, we will move them in next version.
```