RE: [PATCH net-next] net: qed_debug: fix check of false (grc_param < 0) expression
From: Shai Malin <hidden>
Date: 2021-10-12 08:21:29
From: Shai Malin <hidden>
Date: 2021-10-12 08:21:29
On 10/12/21 at 10:47 AM Jεan Sacren wrote:
The type of enum dbg_grc_params has the enumerator list starting from 0. When grc_param is declared by enum dbg_grc_params, (grc_param < 0) is always false. We should remove the check of this expression. Signed-off-by: Jean Sacren <redacted> --- drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.cb/drivers/net/ethernet/qlogic/qed/qed_debug.c index f6198b9a1b02..e3edca187ddf 100644--- a/drivers/net/ethernet/qlogic/qed/qed_debug.c +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c@@ -5256,7 +5256,7 @@ enum dbg_status qed_dbg_grc_config(structqed_hwfn *p_hwfn, */ qed_dbg_grc_init_params(p_hwfn); - if (grc_param >= MAX_DBG_GRC_PARAMS || grc_param < 0) + if (grc_param >= MAX_DBG_GRC_PARAMS) return DBG_STATUS_INVALID_ARGS; if (val < s_grc_param_defs[grc_param].min || val > s_grc_param_defs[grc_param].max)
Thanks. Acked-by: Shai Malin <redacted>