Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data

4 messages, 4 authors, 2021-09-27 · open the first message on its own page

Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data

From: Ilya Leoshkevich <iii@linux.ibm.com>
Date: 2021-09-27 11:33:40

On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
Make sure to free jit_data through kfree() in the error path.

Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
programs")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

RESEND due to the following reason:
[Can not connect to recipient's server because of unstable
network or firewall filter. rcpt handle timeout, last handle
info: Can not connect to vger.kernel.org]

 arch/s390/net/bpf_jit_comp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch, thanks!

Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>

Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2021-09-27 15:27:40

On 9/27/21 1:33 PM, Ilya Leoshkevich wrote:
On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
quoted
Make sure to free jit_data through kfree() in the error path.

Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
programs")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

RESEND due to the following reason:
[Can not connect to recipient's server because of unstable
network or firewall filter. rcpt handle timeout, last handle
info: Can not connect to vger.kernel.org]

  arch/s390/net/bpf_jit_comp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch, thanks!

Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Given s390, I presume this would be routed to Linus via Heiko/Vasily?

Thanks,
Daniel

Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data

From: Christian Borntraeger <hidden>
Date: 2021-09-27 15:59:29


Am 27.09.21 um 17:26 schrieb Daniel Borkmann:
On 9/27/21 1:33 PM, Ilya Leoshkevich wrote:
quoted
On Mon, 2021-09-27 at 15:06 +0800, Tiezhu Yang wrote:
quoted
Make sure to free jit_data through kfree() in the error path.

Fixes: 1c8f9b91c456 ("bpf: s390: add JIT support for multi-function
programs")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

RESEND due to the following reason:
[Can not connect to recipient's server because of unstable
network or firewall filter. rcpt handle timeout, last handle
info: Can not connect to vger.kernel.org]

  arch/s390/net/bpf_jit_comp.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Nice catch, thanks!

Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Makes sense.
Reviewed-by: Christian Borntraeger <redacted>
Given s390, I presume this would be routed to Linus via Heiko/Vasily?
Yes, applied to the s390 tree.

Interestingly enough b4 cannot find the patch email on lore.
Looks like Tiezhu Yang has indeed connection issues with vger.
CC Konstantin, in case he knows something.

Re: [PATCH RESEND bpf] bpf, s390: Fix potential memory leak about jit_data

From: Konstantin Ryabitsev <hidden>
Date: 2021-09-27 16:13:51

On Mon, Sep 27, 2021 at 05:58:54PM +0200, Christian Borntraeger wrote:
Interestingly enough b4 cannot find the patch email on lore.
Looks like Tiezhu Yang has indeed connection issues with vger.
CC Konstantin, in case he knows something.
I'm not actually in charge of vger, so I'm not able to help any further than
adding John to the cc's.

-K
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help