[PATCH] net: cisco: Fix a function name in comments

Subsystems: cisco vic ethernet nic driver, networking drivers, the rest

STALE1770d

3 messages, 3 authors, 2021-09-27 · open the first message on its own page

[PATCH] net: cisco: Fix a function name in comments

From: Cai Huoqing <hidden>
Date: 2021-09-25 12:46:47

Use dma_alloc_coherent() instead of pci_alloc_consistent(),
because only dma_alloc_coherent() is called here.

Signed-off-by: Cai Huoqing <redacted>
---
 drivers/net/ethernet/cisco/enic/enic_ethtool.c | 4 ++--
 drivers/net/ethernet/cisco/enic/enic_main.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/cisco/enic/enic_ethtool.c b/drivers/net/ethernet/cisco/enic/enic_ethtool.c
index 12ffc14fbecd..6ded4d9fa32a 100644
--- a/drivers/net/ethernet/cisco/enic/enic_ethtool.c
+++ b/drivers/net/ethernet/cisco/enic/enic_ethtool.c
@@ -139,7 +139,7 @@ static void enic_get_drvinfo(struct net_device *netdev,
 	int err;
 
 	err = enic_dev_fw_info(enic, &fw_info);
-	/* return only when pci_zalloc_consistent fails in vnic_dev_fw_info
+	/* return only when dma_alloc_coherent fails in vnic_dev_fw_info
 	 * For other failures, like devcmd failure, we return previously
 	 * recorded info.
 	 */
@@ -270,7 +270,7 @@ static void enic_get_ethtool_stats(struct net_device *netdev,
 	int err;
 
 	err = enic_dev_stats_dump(enic, &vstats);
-	/* return only when pci_zalloc_consistent fails in vnic_dev_stats_dump
+	/* return only when dma_alloc_coherent fails in vnic_dev_stats_dump
 	 * For other failures, like devcmd failure, we return previously
 	 * recorded stats.
 	 */
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index d0a8f7106958..13dbdd5d07b4 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -882,7 +882,7 @@ static void enic_get_stats(struct net_device *netdev,
 	int err;
 
 	err = enic_dev_stats_dump(enic, &stats);
-	/* return only when pci_zalloc_consistent fails in vnic_dev_stats_dump
+	/* return only when dma_alloc_coherent fails in vnic_dev_stats_dump
 	 * For other failures, like devcmd failure, we return previously
 	 * recorded stats.
 	 */
-- 
2.25.1

Re: [PATCH] net: cisco: Fix a function name in comments

From: Govindarajulu Varadarajan <hidden>
Date: 2021-09-26 23:46:08

On Sat, Sep 25, 2021 at 5:46 AM Cai Huoqing [off-list ref] wrote:
Use dma_alloc_coherent() instead of pci_alloc_consistent(),
because only dma_alloc_coherent() is called here.

Signed-off-by: Cai Huoqing <redacted>
Thanks.

Reviewed-by: Govindarajulu Varadarajan <redacted>

Re: [PATCH] net: cisco: Fix a function name in comments

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-27 12:30:16

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 25 Sep 2021 20:46:28 +0800 you wrote:
Use dma_alloc_coherent() instead of pci_alloc_consistent(),
because only dma_alloc_coherent() is called here.

Signed-off-by: Cai Huoqing <redacted>
---
 drivers/net/ethernet/cisco/enic/enic_ethtool.c | 4 ++--
 drivers/net/ethernet/cisco/enic/enic_main.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
  - net: cisco: Fix a function name in comments
    https://git.kernel.org/netdev/net-next/c/f947fcaffd6a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help