Re: [PATCH] ath10k: Don't always treat modem stop events as crashes

Stephen Boyd [off-list ref] writes:

Quoting pillair@codeaurora.org (2021-09-21 22:35:34)

quoted

On 9/5/21 4:04 PM, Stephen Boyd wrote:

quoted

+static int ath10k_snoc_modem_notify(struct notifier_block *nb, unsigned long

[...]

quoted

quoted

+

quoted

+          return NOTIFY_OK;

quoted

+}

Thanks for posting the patch. It would be preferable to use a different flag
instead of ATH10K_SNOC_FLAG_UNREGISTERING,

since we are not unloading the ath10k driver.

Weird, I don't see pillair's email on patchwork[1] and not in the ath10k
list either. Was it sent as HTML or something?

[1] https://patchwork.kernel.org/project/linux-wireless/patch/20210905210400.1157870-1-swboyd@chromium.org/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-----Original Message-----
From: Kalle Valo <redacted>
Sent: Friday, September 24, 2021 1:30 PM
To: Stephen Boyd <redacted>
Cc: pillair@codeaurora.org; ath10k@lists.infradead.org;
govinds@codeaurora.org; kuabhs@chromium.org; linux-arm-
msm@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
wireless@vger.kernel.org; netdev@vger.kernel.org;
youghand@codeaurora.org
Subject: Re: [PATCH] ath10k: Don't always treat modem stop events as
crashes

Stephen Boyd [off-list ref] writes:

quoted

Quoting pillair@codeaurora.org (2021-09-21 22:35:34)

quoted

On 9/5/21 4:04 PM, Stephen Boyd wrote:

quoted

+static int ath10k_snoc_modem_notify(struct notifier_block *nb,
+unsigned long

[...]

quoted

quoted

+

quoted

+          return NOTIFY_OK;

quoted

+}

Thanks for posting the patch. It would be preferable to use a
different flag instead of ATH10K_SNOC_FLAG_UNREGISTERING,

since we are not unloading the ath10k driver.

Weird, I don't see pillair's email on patchwork[1] and not in the ath10k

list

either. Was it sent as HTML or something?

Hi Kalle,
Yes, I replied via the "In-reply-to" from the patchworks[1] link.

Thanks,
Rakesh Pillai

[1] https://patchwork.kernel.org/project/linux-
wireless/patch/20210905210400.1157870-1-swboyd@chromium.org/

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingp
atches