[PATCH -next v2] net/ipv4/sysctl_net_ipv4.c: remove superfluous header files from sysctl_net_ipv4.c

Subsystems: networking [general], the rest

STALE1778d

2 messages, 2 authors, 2021-09-21 · open the first message on its own page

[PATCH -next v2] net/ipv4/sysctl_net_ipv4.c: remove superfluous header files from sysctl_net_ipv4.c

From: Mianhan Liu <hidden>
Date: 2021-09-21 07:48:13

sysctl_net_ipv4.c hasn't use any macro or function declared in igmp.h,
inetdevice.h, mm.h, module.h, nsproxy.h, swap.h, inet_frag.h, route.h
and snmp.h. Thus, these files can be removed from sysctl_net_ipv4.c
safely without affecting the compilation of the net module.

Signed-off-by: Mianhan Liu <redacted>

---
 net/ipv4/sysctl_net_ipv4.c | 9 ---------
 1 file changed, 9 deletions(-)
diff --git a/net/ipv4/sysctl_net_ipv4.c b/net/ipv4/sysctl_net_ipv4.c
index 6f1e64d49..4680268f2 100644
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@ -6,25 +6,16 @@
  * Added /proc/sys/net/ipv4 directory entry (empty =) ). [MS]
  */
 
-#include <linux/mm.h>
-#include <linux/module.h>
 #include <linux/sysctl.h>
-#include <linux/igmp.h>
-#include <linux/inetdevice.h>
 #include <linux/seqlock.h>
 #include <linux/init.h>
 #include <linux/slab.h>
-#include <linux/nsproxy.h>
-#include <linux/swap.h>
-#include <net/snmp.h>
 #include <net/icmp.h>
 #include <net/ip.h>
 #include <net/ip_fib.h>
-#include <net/route.h>
 #include <net/tcp.h>
 #include <net/udp.h>
 #include <net/cipso_ipv4.h>
-#include <net/inet_frag.h>
 #include <net/ping.h>
 #include <net/protocol.h>
 #include <net/netevent.h>
-- 
2.25.1

Re: [PATCH -next v2] net/ipv4/sysctl_net_ipv4.c: remove superfluous header files from sysctl_net_ipv4.c

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-21 10:10:28

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 21 Sep 2021 15:47:51 +0800 you wrote:
sysctl_net_ipv4.c hasn't use any macro or function declared in igmp.h,
inetdevice.h, mm.h, module.h, nsproxy.h, swap.h, inet_frag.h, route.h
and snmp.h. Thus, these files can be removed from sysctl_net_ipv4.c
safely without affecting the compilation of the net module.

Signed-off-by: Mianhan Liu <redacted>

[...]
Here is the summary with links:
  - [-next,v2] net/ipv4/sysctl_net_ipv4.c: remove superfluous header files from sysctl_net_ipv4.c
    https://git.kernel.org/netdev/net-next/c/07b855628c22

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help