Re: [PATCH] brcmfmac: Replace zero-length array with flexible array member

2 messages, 2 authors, 2021-09-21 · open the first message on its own page

Re: [PATCH] brcmfmac: Replace zero-length array with flexible array member

From: Kalle Valo <hidden>
Date: 2021-09-21 05:56:24

Kalle Valo [off-list ref] writes:
"Gustavo A. R. Silva" [off-list ref] writes:
quoted
On Sat, Sep 04, 2021 at 11:22:17AM +0200, Len Baker wrote:
quoted
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use "flexible array members"[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].

Also, make use of the struct_size() helper in devm_kzalloc().

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2]
https://www.kernel.org/doc/html/v5.14/process/deprecated.html#zero-length-and-one-element-arrays

Signed-off-by: Len Baker <redacted>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>

I'll take this in my -next tree. :)
Why? It should go to wireless-drivers-next.
Gustavo, so have you dropped this from your tree now? I do not want to
get any conflicts because of this.

I'll reiterate again: do not take any patches touching
drivers/net/wireless unless I have acked them.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] brcmfmac: Replace zero-length array with flexible array member

From: Gustavo A. R. Silva <hidden>
Date: 2021-09-21 17:33:35


On 9/21/21 00:55, Kalle Valo wrote:
Gustavo, so have you dropped this from your tree now? I do not want to
get any conflicts because of this.
It's not on my tree.
I'll reiterate again: do not take any patches touching
drivers/net/wireless unless I have acked them.
Got it.

--
Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help