From: Yajun Deng <hidden> Date: 2021-09-18 06:37:02
It no need barrier when assigning a NULL value to an RCU protected
pointer. So use RCU_INIT_POINTER() instead for more fast.
Signed-off-by: Yajun Deng <redacted>
---
net/core/rtnetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -301,7 +301,7 @@ int rtnl_unregister(int protocol, int msgtype)}link=rtnl_dereference(tab[msgindex]);-rcu_assign_pointer(tab[msgindex],NULL);+RCU_INIT_POINTER(tab[msgindex],NULL);rtnl_unlock();kfree_rcu(link,rcu);
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 18 Sep 2021 14:36:07 +0800 you wrote:
It no need barrier when assigning a NULL value to an RCU protected
pointer. So use RCU_INIT_POINTER() instead for more fast.
Signed-off-by: Yajun Deng <redacted>
---
net/core/rtnetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Eric Dumazet <hidden> Date: 2021-09-23 17:09:31
On 9/17/21 11:36 PM, Yajun Deng wrote:
quoted hunk
It no need barrier when assigning a NULL value to an RCU protected
pointer. So use RCU_INIT_POINTER() instead for more fast.
Signed-off-by: Yajun Deng <redacted>
---
net/core/rtnetlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -301,7 +301,7 @@ int rtnl_unregister(int protocol, int msgtype)}link=rtnl_dereference(tab[msgindex]);-rcu_assign_pointer(tab[msgindex],NULL);+RCU_INIT_POINTER(tab[msgindex],NULL);rtnl_unlock();kfree_rcu(link,rcu);
FYI, there is no memory barrier involved in
rcu_assign_pointer(tab[msgindex], NULL);
This has been the case for the last 5 years.
Your patch was not needed really.