[PATCH][next] octeontx2-af: Remove redundant initialization of variable blkaddr

Subsystems: marvell octeontx2 rvu admin function driver, networking drivers, the rest

STALE1779d

2 messages, 2 authors, 2021-09-17 · open the first message on its own page

[PATCH][next] octeontx2-af: Remove redundant initialization of variable blkaddr

From: Colin King <hidden>
Date: 2021-09-17 12:03:37

From: Colin Ian King <redacted>

The variable blkaddr is being initialized with a value that is never
read, it is being updated later on in a for-loop. The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
index 3bba8bc91f35..5909173ff788 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
@@ -1294,7 +1294,7 @@ int rvu_get_blkaddr_from_slot(struct rvu *rvu, int blktype, u16 pcifunc,
 	int numlfs, total_lfs = 0, nr_blocks = 0;
 	int i, num_blkaddr[BLK_COUNT] = { 0 };
 	struct rvu_block *block;
-	int blkaddr = -ENODEV;
+	int blkaddr;
 	u16 start_slot;
 
 	if (!is_blktype_attached(pfvf, blktype))
-- 
2.32.0

Re: [PATCH][next] octeontx2-af: Remove redundant initialization of variable blkaddr

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-17 13:10:10

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 17 Sep 2021 13:03:33 +0100 you wrote:
From: Colin Ian King <redacted>

The variable blkaddr is being initialized with a value that is never
read, it is being updated later on in a for-loop. The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>

[...]
Here is the summary with links:
  - [next] octeontx2-af: Remove redundant initialization of variable blkaddr
    https://git.kernel.org/netdev/net-next/c/3503e673db23

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help