# Re: \[PATCH V5 07/12\] Drivers: hv: vmbus: Add SNP support for VMbus channel initiate message

- From: Tianyu Lan \<hidden\>
- Date: 2021-09-16 10:52:39 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/09/1510362
- Thread: https://ratatoskr.run/xen-devel/2021/09/1507894/t.md

```text
On 9/15/2021 11:41 PM, Michael Kelley wrote:
>> diff --git a/drivers/hv/hyperv_vmbus.h b/drivers/hv/hyperv_vmbus.h
>> index 42f3d9d123a1..560cba916d1d 100644
>> --- a/drivers/hv/hyperv_vmbus.h
>> +++ b/drivers/hv/hyperv_vmbus.h
>> @@ -240,6 +240,8 @@ struct vmbus_connection {
>>   	 * is child->parent notification
>>   	 */
>>   	struct hv_monitor_page *monitor_pages[2];
>> +	void *monitor_pages_original[2];
>> +	unsigned long monitor_pages_pa[2];
> The type of this field really should be phys_addr_t.  In addition to
> just making semantic sense, then it will match the return type from
> virt_to_phys() and the input arg to memremap() since resource_size_t
> is typedef'ed as phys_addr_t.
>

OK. Will update in the next version.

Thanks.
```