[PATCH] net: chelsio: cxgb4vf: Make use of the helper function dev_err_probe()

Subsystems: cxgb4vf ethernet driver (cxgb4vf), networking drivers, the rest

STALE1782d

2 messages, 2 authors, 2021-09-16 · open the first message on its own page

[PATCH] net: chelsio: cxgb4vf: Make use of the helper function dev_err_probe()

From: Cai Huoqing <hidden>
Date: 2021-09-15 15:14:40

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: Cai Huoqing <redacted>
---
 drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
index 49b76fd47daa..4920a80a0460 100644
--- a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c
@@ -2902,10 +2902,8 @@ static int cxgb4vf_pci_probe(struct pci_dev *pdev,
 	 * Initialize generic PCI device state.
 	 */
 	err = pci_enable_device(pdev);
-	if (err) {
-		dev_err(&pdev->dev, "cannot enable PCI device\n");
-		return err;
-	}
+	if (err)
+		return dev_err_probe(&pdev->dev, err, "cannot enable PCI device\n");
 
 	/*
 	 * Reserve PCI resources for the device.  If we can't get them some
-- 
2.25.1

Re: [PATCH] net: chelsio: cxgb4vf: Make use of the helper function dev_err_probe()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-16 12:40:38

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 15 Sep 2021 22:58:11 +0800 you wrote:
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.

Signed-off-by: Cai Huoqing <redacted>

[...]
Here is the summary with links:
  - net: chelsio: cxgb4vf: Make use of the helper function dev_err_probe()
    https://git.kernel.org/netdev/net-next/c/9eda994d4b57

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help