[PATCH] qlcnic: Remove redundant initialization of variable ret

Subsystems: networking drivers, qlogic qlcnic (1/10)gb ethernet driver, the rest

STALE1788d

2 messages, 2 authors, 2021-09-10 · open the first message on its own page

[PATCH] qlcnic: Remove redundant initialization of variable ret

From: Colin King <hidden>
Date: 2021-09-10 11:15:17

From: Colin Ian King <redacted>

The variable ret is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
index 0a2f34fc8b24..27dffa299ca6 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
@@ -1354,10 +1354,10 @@ static int qlcnic_83xx_copy_fw_file(struct qlcnic_adapter *adapter)
 	struct qlc_83xx_fw_info *fw_info = adapter->ahw->fw_info;
 	const struct firmware *fw = fw_info->fw;
 	u32 dest, *p_cache, *temp;
-	int i, ret = -EIO;
 	__le32 *temp_le;
 	u8 data[16];
 	size_t size;
+	int i, ret;
 	u64 addr;
 
 	temp = vzalloc(fw->size);
-- 
2.32.0

Re: [PATCH] qlcnic: Remove redundant initialization of variable ret

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-10 13:50:12

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 10 Sep 2021 12:15:11 +0100 you wrote:
From: Colin Ian King <redacted>

The variable ret is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <redacted>

[...]
Here is the summary with links:
  - qlcnic: Remove redundant initialization of variable ret
    https://git.kernel.org/netdev/net/c/666eb96d85dc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help