3 messages, 2 authors, 2021-09-09 · open the first message on its own page
From: Ujjal Roy <hidden>
Date: 2021-09-08 02:26:03
Hi All, Before sending the patch, I am writing this email to get your attention please. As per my knowledge I can see ip6mr_cache_report() has some indentation issues. Please have a look at the line 1085. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv6/ip6mr.c#n1085 Sharing a patch based on the latest stable Linux. Thanks, UjjaL Roy
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-08 16:33:19
On Wed, 8 Sep 2021 07:55:45 +0530 Ujjal Roy wrote:
Hi All, Before sending the patch, I am writing this email to get your attention please. As per my knowledge I can see ip6mr_cache_report() has some indentation issues. Please have a look at the line 1085. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv6/ip6mr.c#n1085 Sharing a patch based on the latest stable Linux.
Please repost with the patch being inline in the email.
Try to use git format-patch and git send-email for best results.
The subject prefix should be [PATCH net-next].
Regarding the change itself - since you're changing this code could you
also remove the ifdef? Instead of:
#ifdef CONFIG_IPV6_PIMSM_V2
if (assert == MRT6MSG_WHOLEPKT) {
do:
if (IS_ENABLED(CONFIG_IPV6_PIMSM_V2) && assert == MRT6MSG_WHOLEPKT) {
From: Ujjal Roy <hidden>
Date: 2021-09-09 14:14:24
Thanks for the suggestion, I will do that change and will submit a patch. Thanks, UjjaL Roy On Wed, Sep 8, 2021 at 10:03 PM Jakub Kicinski [off-list ref] wrote:
On Wed, 8 Sep 2021 07:55:45 +0530 Ujjal Roy wrote:quoted
Hi All, Before sending the patch, I am writing this email to get your attention please. As per my knowledge I can see ip6mr_cache_report() has some indentation issues. Please have a look at the line 1085. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/ipv6/ip6mr.c#n1085 Sharing a patch based on the latest stable Linux.Please repost with the patch being inline in the email. Try to use git format-patch and git send-email for best results. The subject prefix should be [PATCH net-next]. Regarding the change itself - since you're changing this code could you also remove the ifdef? Instead of: #ifdef CONFIG_IPV6_PIMSM_V2 if (assert == MRT6MSG_WHOLEPKT) { do: if (IS_ENABLED(CONFIG_IPV6_PIMSM_V2) && assert == MRT6MSG_WHOLEPKT) {