[PATCH v1 1/1] bonding: complain about missing route only once for A/B ARP probes

Subsystems: bonding driver, networking drivers, the rest

STALE1794d

2 messages, 2 authors, 2021-09-05 · open the first message on its own page

[PATCH v1 1/1] bonding: complain about missing route only once for A/B ARP probes

From: David Decotigny <hidden>
Date: 2021-09-04 06:31:47

From: David Decotigny <redacted>

On configs where there is no confirgured direct route to the target of
the ARP probes, these probes are still sent and may be replied to
properly, so no need to repeatedly complain about the missing route.


Signed-off-by: David Decotigny <redacted>
---
 drivers/net/bonding/bond_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index b0966e733926..3858da3d3ea7 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2910,9 +2910,9 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
 			 * probe to generate any traffic (arp_validate=0)
 			 */
 			if (bond->params.arp_validate)
-				net_warn_ratelimited("%s: no route to arp_ip_target %pI4 and arp_validate is set\n",
-						     bond->dev->name,
-						     &targets[i]);
+				pr_warn_once("%s: no route to arp_ip_target %pI4 and arp_validate is set\n",
+					     bond->dev->name,
+					     &targets[i]);
 			bond_arp_send(slave, ARPOP_REQUEST, targets[i],
 				      0, tags);
 			continue;
-- 
2.33.0.153.gba50c8fa24-goog

Re: [PATCH v1 1/1] bonding: complain about missing route only once for A/B ARP probes

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-05 12:20:10

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri,  3 Sep 2021 23:31:29 -0700 you wrote:
From: David Decotigny <redacted>

On configs where there is no confirgured direct route to the target of
the ARP probes, these probes are still sent and may be replied to
properly, so no need to repeatedly complain about the missing route.


[...]
Here is the summary with links:
  - [v1,1/1] bonding: complain about missing route only once for A/B ARP probes
    https://git.kernel.org/netdev/net/c/0a4fd8df07dd

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help