[PATCH] p54: Remove obsolete comment

Subsystems: p54 wireless driver, the rest

STALE1826d

2 messages, 2 authors, 2021-09-01 · open the first message on its own page

[PATCH] p54: Remove obsolete comment

From: Wan Jiabing <hidden>
Date: 2021-09-01 02:48:02 

In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
prism54/isl_oid.h is deleted. The comment here is obsolete.

Signed-off-by: Wan Jiabing <redacted>
---
 drivers/net/wireless/intersil/p54/fwio.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
index bece14e4ff0d..1fe072de3e63 100644
--- a/drivers/net/wireless/intersil/p54/fwio.c
+++ b/drivers/net/wireless/intersil/p54/fwio.c
@@ -583,7 +583,6 @@ int p54_set_edcf(struct p54_common *priv)
 	rtd = 3 * priv->coverage_class;
 	edcf->slottime += rtd;
 	edcf->round_trip_delay = cpu_to_le16(rtd);
-	/* (see prism54/isl_oid.h for further details) */
 	edcf->frameburst = cpu_to_le16(0);
 	edcf->flags = 0;
 	memset(edcf->mapping, 0, sizeof(edcf->mapping));
-- 
2.25.1

Re: [PATCH] p54: Remove obsolete comment

From: Christian Lamparter <hidden>
Date: 2021-09-01 17:40:11 

On 01/09/2021 04:47, Wan Jiabing wrote:
In commit d249ff28b1d8 ("intersil: remove obsolete prism54 wireless driver"),
prism54/isl_oid.h is deleted. The comment here is obsolete.
Instead of removing said "obsolete" comment, why not copy the
excellent comment about that "frameburst technology" from the
prism54/isl_oid.h file there?

Cheers,
Christian
quoted hunk
Signed-off-by: Wan Jiabing <redacted>
---
  drivers/net/wireless/intersil/p54/fwio.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c
index bece14e4ff0d..1fe072de3e63 100644
--- a/drivers/net/wireless/intersil/p54/fwio.c
+++ b/drivers/net/wireless/intersil/p54/fwio.c
@@ -583,7 +583,6 @@ int p54_set_edcf(struct p54_common *priv)
  	rtd = 3 * priv->coverage_class;
  	edcf->slottime += rtd;
  	edcf->round_trip_delay = cpu_to_le16(rtd);
-	/* (see prism54/isl_oid.h for further details) */
  	edcf->frameburst = cpu_to_le16(0);
  	edcf->flags = 0;
  	memset(edcf->mapping, 0, sizeof(edcf->mapping));




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help