From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Date: 2021-09-28 14:11:28
From: Thomas Gleixner <redacted>
The sequence count bridge_mcast_querier::seq is protected by
net_bridge::multicast_lock but seqcount_init() does not associate the
seqcount with the lock. This leads to a warning on PREEMPT_RT because
preemption is still enabled.
Let seqcount_init() associate the seqcount with lock that protects the
write section. Remove lockdep_assert_held_once() because lockdep already checks
whether the associated lock is held.
Fixes: 67b746f94ff39 ("net: bridge: mcast: make sure querier port/address updates are consistent")
Reported-by: Mike Galbraith <redacted>
Signed-off-by: Thomas Gleixner <redacted>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: Mike Galbraith <redacted>
---
net/bridge/br_multicast.c | 6 ++----
net/bridge/br_private.h | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
From: Nikolay Aleksandrov <hidden> Date: 2021-09-28 14:41:38
On 28/09/2021 17:10, Sebastian Andrzej Siewior wrote:
quoted hunk
From: Thomas Gleixner <redacted>
The sequence count bridge_mcast_querier::seq is protected by
net_bridge::multicast_lock but seqcount_init() does not associate the
seqcount with the lock. This leads to a warning on PREEMPT_RT because
preemption is still enabled.
Let seqcount_init() associate the seqcount with lock that protects the
write section. Remove lockdep_assert_held_once() because lockdep already checks
whether the associated lock is held.
Fixes: 67b746f94ff39 ("net: bridge: mcast: make sure querier port/address updates are consistent")
Reported-by: Mike Galbraith <redacted>
Signed-off-by: Thomas Gleixner <redacted>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Tested-by: Mike Galbraith <redacted>
---
net/bridge/br_multicast.c | 6 ++----
net/bridge/br_private.h | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 28 Sep 2021 16:10:49 +0200 you wrote:
From: Thomas Gleixner <redacted>
The sequence count bridge_mcast_querier::seq is protected by
net_bridge::multicast_lock but seqcount_init() does not associate the
seqcount with the lock. This leads to a warning on PREEMPT_RT because
preemption is still enabled.
[...]