[PATCH net] net: sun: SUNVNET_COMMON should depend on INET

STALE1773d

2 messages, 2 authors, 2021-09-28 · open the first message on its own page

[PATCH net] net: sun: SUNVNET_COMMON should depend on INET

From: Randy Dunlap <hidden>
Date: 2021-09-27 21:48:29

When CONFIG_INET is not set, there are failing references to IPv4
functions, so make this driver depend on INET.

Fixes these build errors:

sparc64-linux-ld: drivers/net/ethernet/sun/sunvnet_common.o: in function `sunvnet_start_xmit_common':
sunvnet_common.c:(.text+0x1a68): undefined reference to `__icmp_send'
sparc64-linux-ld: drivers/net/ethernet/sun/sunvnet_common.o: in function `sunvnet_poll_common':
sunvnet_common.c:(.text+0x358c): undefined reference to `ip_send_check'

Signed-off-by: Randy Dunlap <redacted>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Aaron Young <redacted>
Cc: Rashmi Narasimhan <redacted>
---
Fixes: prior to 31762eaa0d08 ("ldmvsw: Split sunvnet driver into common code")
[I don't have enough git fu to go back beyond this.]

 drivers/net/ethernet/sun/Kconfig |    1 +
 1 file changed, 1 insertion(+)
--- linux-next-20210927.orig/drivers/net/ethernet/sun/Kconfig
+++ linux-next-20210927/drivers/net/ethernet/sun/Kconfig
@@ -73,6 +73,7 @@ config CASSINI
 config SUNVNET_COMMON
 	tristate "Common routines to support Sun Virtual Networking"
 	depends on SUN_LDOMS
+	depends on INET
 	default m
 
 config SUNVNET

Re: [PATCH net] net: sun: SUNVNET_COMMON should depend on INET

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-28 12:30:14

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 27 Sep 2021 14:48:23 -0700 you wrote:
When CONFIG_INET is not set, there are failing references to IPv4
functions, so make this driver depend on INET.

Fixes these build errors:

sparc64-linux-ld: drivers/net/ethernet/sun/sunvnet_common.o: in function `sunvnet_start_xmit_common':
sunvnet_common.c:(.text+0x1a68): undefined reference to `__icmp_send'
sparc64-linux-ld: drivers/net/ethernet/sun/sunvnet_common.o: in function `sunvnet_poll_common':
sunvnet_common.c:(.text+0x358c): undefined reference to `ip_send_check'

[...]
Here is the summary with links:
  - [net] net: sun: SUNVNET_COMMON should depend on INET
    https://git.kernel.org/netdev/net/c/103bde372f08

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help