[PATCH net] net/mlx4_en: Don't allow aRFS for encapsulated packets

Subsystems: mellanox ethernet driver (mlx4_en), mellanox mlx4 core vpi driver, networking drivers, the rest

STALE1776d

2 messages, 2 authors, 2021-09-23 · open the first message on its own page

[PATCH net] net/mlx4_en: Don't allow aRFS for encapsulated packets

From: Tariq Toukan <tariqt@nvidia.com>
Date: 2021-09-23 06:52:10

From: Aya Levin <redacted>

Driver doesn't support aRFS for encapsulated packets, return early error
in such a case.

Fixes: 1eb8c695bda9 ("net/mlx4_en: Add accelerated RFS support")
Signed-off-by: Aya Levin <redacted>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 3 +++
 1 file changed, 3 insertions(+)

Hi,
Please queue to -stable.

Regards,
Tariq
diff --git a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
index 35154635ec3a..8af7f2827322 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_netdev.c
@@ -372,6 +372,9 @@ mlx4_en_filter_rfs(struct net_device *net_dev, const struct sk_buff *skb,
 	int nhoff = skb_network_offset(skb);
 	int ret = 0;
 
+	if (skb->encapsulation)
+		return -EPROTONOSUPPORT;
+
 	if (skb->protocol != htons(ETH_P_IP))
 		return -EPROTONOSUPPORT;
 
-- 
2.21.0

Re: [PATCH net] net/mlx4_en: Don't allow aRFS for encapsulated packets

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-23 12:20:16

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 23 Sep 2021 09:51:45 +0300 you wrote:
From: Aya Levin <redacted>

Driver doesn't support aRFS for encapsulated packets, return early error
in such a case.

Fixes: 1eb8c695bda9 ("net/mlx4_en: Add accelerated RFS support")
Signed-off-by: Aya Levin <redacted>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

[...]
Here is the summary with links:
  - [net] net/mlx4_en: Don't allow aRFS for encapsulated packets
    https://git.kernel.org/netdev/net/c/fdbccea419dc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help