[PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection

STALE1778d

3 messages, 3 authors, 2021-09-20 · open the first message on its own page

[PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection

From: M Chetan Kumar <hidden>
Date: 2021-09-19 17:26:27

This patch series brings-in support for M.2 7560 Device firmware flashing &
coredump collection using devlink.
- Driver Registers with Devlink framework.
- Register devlink params callback for configuring device params
  required in flashing or coredump flow.
- Implements devlink ops flash_update callback that programs modem
  firmware.
- Creates region & snapshot required for device coredump log collection.

On early detection of device in boot rom stage. Driver registers with
Devlink framework and establish transport channel for PSI (Primary Signed
Image) injection. Once PSI is injected to device, the device execution
stage details are read to determine whether device is in flash or
exception mode. The collected information is reported to devlink user
space application & based on this informationi, application proceeds with
either modem firmware flashing or coredump collection.

Refer to iosm devlink documentation for details on Devlink Params, flash
update and coredump collection command usage.

Note: Patches are interdependent. Need to apply complete patch series for
compilation.

Changes since v1:
  * Break down single patch into multiple patches.
  * IOSM Driver devlink documentation.
  * Fixes NULL parameter deference in ipc_devlink_flash_update() reported
    by smatch static checker.
  * Fixes memory leak in ipc_devlink_create_region().
  * Use kmemdup instead of kzalloc and memcpy in ipc_flash_boot_psi().
  * Fixes linux-net build error.

M Chetan Kumar (6):
  net: wwan: iosm: devlink registration
  net: wwan: iosm: fw flashing support
  net: wwan: iosm: coredump collection support
  net: wwan: iosm: transport layer support for fw flashing/cd
  net: wwan: iosm: devlink fw flashing & cd collection documentation
  net: wwan: iosm: fw flashing & cd collection infrastructure changes

 Documentation/networking/devlink/index.rst |   1 +
 Documentation/networking/devlink/iosm.rst  | 182 +++++++
 drivers/net/wwan/Kconfig                   |   1 +
 drivers/net/wwan/iosm/Makefile             |   5 +-
 drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.c  |   6 +-
 drivers/net/wwan/iosm/iosm_ipc_chnl_cfg.h  |   1 +
 drivers/net/wwan/iosm/iosm_ipc_coredump.c  | 110 ++++
 drivers/net/wwan/iosm/iosm_ipc_coredump.h  |  75 +++
 drivers/net/wwan/iosm/iosm_ipc_devlink.c   | 363 +++++++++++++
 drivers/net/wwan/iosm/iosm_ipc_devlink.h   | 207 ++++++++
 drivers/net/wwan/iosm/iosm_ipc_flash.c     | 561 +++++++++++++++++++++
 drivers/net/wwan/iosm/iosm_ipc_flash.h     | 271 ++++++++++
 drivers/net/wwan/iosm/iosm_ipc_imem.c      | 103 +++-
 drivers/net/wwan/iosm/iosm_ipc_imem.h      |  18 +-
 drivers/net/wwan/iosm/iosm_ipc_imem_ops.c  | 317 ++++++++++++
 drivers/net/wwan/iosm/iosm_ipc_imem_ops.h  |  49 +-
 16 files changed, 2239 insertions(+), 31 deletions(-)
 create mode 100644 Documentation/networking/devlink/iosm.rst
 create mode 100644 drivers/net/wwan/iosm/iosm_ipc_coredump.c
 create mode 100644 drivers/net/wwan/iosm/iosm_ipc_coredump.h
 create mode 100644 drivers/net/wwan/iosm/iosm_ipc_devlink.c
 create mode 100644 drivers/net/wwan/iosm/iosm_ipc_devlink.h
 create mode 100644 drivers/net/wwan/iosm/iosm_ipc_flash.c
 create mode 100644 drivers/net/wwan/iosm/iosm_ipc_flash.h

-- 
2.25.1

Re: [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-20 09:12:24

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Sun, 19 Sep 2021 22:54:24 +0530 you wrote:
This patch series brings-in support for M.2 7560 Device firmware flashing &
coredump collection using devlink.
- Driver Registers with Devlink framework.
- Register devlink params callback for configuring device params
  required in flashing or coredump flow.
- Implements devlink ops flash_update callback that programs modem
  firmware.
- Creates region & snapshot required for device coredump log collection.

[...]
Here is the summary with links:
  - [V2,net-next,1/6] net: wwan: iosm: devlink registration
    https://git.kernel.org/netdev/net-next/c/4dcd183fbd67
  - [V2,net-next,2/6] net: wwan: iosm: fw flashing support
    https://git.kernel.org/netdev/net-next/c/b55734745568
  - [V2,net-next,3/6] net: wwan: iosm: coredump collection support
    https://git.kernel.org/netdev/net-next/c/09e7b002ff67
  - [V2,net-next,4/6] net: wwan: iosm: transport layer support for fw flashing/cd
    https://git.kernel.org/netdev/net-next/c/8d9be0634181
  - [V2,net-next,5/6] net: wwan: iosm: devlink fw flashing & cd collection documentation
    https://git.kernel.org/netdev/net-next/c/64302024bce5
  - [V2,net-next,6/6] net: wwan: iosm: fw flashing & cd collection infrastructure changes
    https://git.kernel.org/netdev/net-next/c/607d574aba6e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH V2 net-next 0/6] net: wwan: iosm: fw flashing & cd collection

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-20 20:30:05

On Mon, 20 Sep 2021 09:10:11 +0000 patchwork-bot+netdevbpf@kernel.org
wrote:
On Sun, 19 Sep 2021 22:54:24 +0530 you wrote:
quoted
This patch series brings-in support for M.2 7560 Device firmware flashing &
coredump collection using devlink.
- Driver Registers with Devlink framework.
- Register devlink params callback for configuring device params
  required in flashing or coredump flow.
- Implements devlink ops flash_update callback that programs modem
  firmware.
- Creates region & snapshot required for device coredump log collection.

[...]  
Here is the summary with links:
  - [V2,net-next,1/6] net: wwan: iosm: devlink registration
    https://git.kernel.org/netdev/net-next/c/4dcd183fbd67
  - [V2,net-next,2/6] net: wwan: iosm: fw flashing support
    https://git.kernel.org/netdev/net-next/c/b55734745568
  - [V2,net-next,3/6] net: wwan: iosm: coredump collection support
    https://git.kernel.org/netdev/net-next/c/09e7b002ff67
  - [V2,net-next,4/6] net: wwan: iosm: transport layer support for fw flashing/cd
    https://git.kernel.org/netdev/net-next/c/8d9be0634181
  - [V2,net-next,5/6] net: wwan: iosm: devlink fw flashing & cd collection documentation
    https://git.kernel.org/netdev/net-next/c/64302024bce5
  - [V2,net-next,6/6] net: wwan: iosm: fw flashing & cd collection infrastructure changes
    https://git.kernel.org/netdev/net-next/c/607d574aba6e

You are awesome, thank you!
I had to post a revert of v1 because it was merged too quickly,
and the same exact thing happens to v2. Maybe it's just me but 
feels very disheartening.

The flashing API is really easy to extended all the devlink params 
here should be part of the flashing API.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help