[PATCH RESEND net-next] net: dpaa2-mac: add support for more ethtool 10G link modes

Subsystems: dpaa2 ethernet driver, networking drivers, the rest

STALE1778d REVIEWED: 9 (9M)

2 review trailers (1 from subsystem maintainers).

2 messages, 2 authors, 2021-09-19 · open the first message on its own page

[PATCH RESEND net-next] net: dpaa2-mac: add support for more ethtool 10G link modes

From: Russell King <hidden>
Date: 2021-09-17 13:41:22

Phylink documentation says:
  Note that the PHY may be able to transform from one connection
  technology to another, so, eg, don't clear 1000BaseX just
  because the MAC is unable to BaseX mode. This is more about
  clearing unsupported speeds and duplex settings. The port modes
  should not be cleared; phylink_set_port_modes() will help with this.

So add the missing 10G modes.

Signed-off-by: Russell King <redacted>
Acked-by: Marek Behún <kabel@kernel.org>
Acked-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
This was supposed to be merged for the previous merge window, and
further patches applied thereafter, but someone decided to mark it in
patchwork as needing further work presumably while the discussion was
still on-going. netdev patchwork really needs some way to inform
authors that the fate of their patch has been decided, other than just
the "applied" messages.

 drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index ae6d382d8735..543c1f202420 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
 	case PHY_INTERFACE_MODE_10GBASER:
 	case PHY_INTERFACE_MODE_USXGMII:
 		phylink_set(mask, 10000baseT_Full);
+		phylink_set(mask, 10000baseCR_Full);
+		phylink_set(mask, 10000baseSR_Full);
+		phylink_set(mask, 10000baseLR_Full);
+		phylink_set(mask, 10000baseLRM_Full);
+		phylink_set(mask, 10000baseER_Full);
 		if (state->interface == PHY_INTERFACE_MODE_10GBASER)
 			break;
 		phylink_set(mask, 5000baseT_Full);
-- 
2.30.2

Re: [PATCH RESEND net-next] net: dpaa2-mac: add support for more ethtool 10G link modes

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-19 11:20:26

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 17 Sep 2021 14:41:17 +0100 you wrote:
Phylink documentation says:
  Note that the PHY may be able to transform from one connection
  technology to another, so, eg, don't clear 1000BaseX just
  because the MAC is unable to BaseX mode. This is more about
  clearing unsupported speeds and duplex settings. The port modes
  should not be cleared; phylink_set_port_modes() will help with this.

[...]
Here is the summary with links:
  - [RESEND,net-next] net: dpaa2-mac: add support for more ethtool 10G link modes
    https://git.kernel.org/netdev/net-next/c/9eb7b5e7cb50

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help