# Re: \[PATCH net-next 8/8\] net: dsa: rtl8366: Drop and depromote pointless prints

- From: Vladimir Oltean \<olteanv@gmail.com\>
- Date: 2021-09-13 17:38:16 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/09/11211113
- Thread: https://ratatoskr.run/netdev/2021/09/11211089/t.md

```text
On Mon, Sep 13, 2021 at 10:35:53AM -0700, Florian Fainelli wrote:
> On 9/13/2021 7:43 AM, Linus Walleij wrote:
> > We don't need a message for every VLAN association, dbg
> > is fine. The message about adding the DSA or CPU
> > port to a VLAN is directly misleading, this is perfectly
> > fine.
> > 
> > Cc: Vladimir Oltean <olteanv@gmail.com>
> > Cc: Mauri Sandberg <redacted>
> > Cc: Alvin Šipraga <redacted>
> > Cc: Florian Fainelli <f.fainelli@gmail.com>
> > Cc: DENG Qingfang <dqfext@gmail.com>
> > Signed-off-by: Linus Walleij <redacted>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
> Maybe at some point we should think about moving that kind of debugging
> messages towards the DSA core, and just leave drivers with debug prints that
> track an internal state not visible to the DSA framework.

I have some trace points on the bridge driver and in DSA for FDB
entries, maybe something along those lines?
```