[PATCH net] selftest: net: fix typo in altname test

Subsystems: kernel selftest framework, networking [general], the rest

STALE1815d

2 messages, 2 authors, 2021-09-12 · open the first message on its own page

[PATCH net] selftest: net: fix typo in altname test

From: Andrea Claudi <hidden>
Date: 2021-09-11 14:14:38

If altname deletion of the short alternative name fails, the error
message printed is: "Failed to add short alternative name".
This is obviously a typo, as we are testing altname deletion.

Fix this using a proper error message.

Fixes: f95e6c9c4617 ("selftest: net: add alternative names test")
Signed-off-by: Andrea Claudi <redacted>
---
 tools/testing/selftests/net/altnames.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/altnames.sh b/tools/testing/selftests/net/altnames.sh
index 4254ddc3f70b..1ef9e4159bba 100755
--- a/tools/testing/selftests/net/altnames.sh
+++ b/tools/testing/selftests/net/altnames.sh
@@ -45,7 +45,7 @@ altnames_test()
 	check_err $? "Got unexpected long alternative name from link show JSON"
 
 	ip link property del $DUMMY_DEV altname $SHORT_NAME
-	check_err $? "Failed to add short alternative name"
+	check_err $? "Failed to delete short alternative name"
 
 	ip -j -p link show $SHORT_NAME &>/dev/null
 	check_fail $? "Unexpected success while trying to do link show with deleted short alternative name"
-- 
2.31.1

Re: [PATCH net] selftest: net: fix typo in altname test

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-09-12 09:50:10

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Sat, 11 Sep 2021 16:14:18 +0200 you wrote:
If altname deletion of the short alternative name fails, the error
message printed is: "Failed to add short alternative name".
This is obviously a typo, as we are testing altname deletion.

Fix this using a proper error message.

Fixes: f95e6c9c4617 ("selftest: net: add alternative names test")
Signed-off-by: Andrea Claudi <redacted>

[...]
Here is the summary with links:
  - [net] selftest: net: fix typo in altname test
    https://git.kernel.org/netdev/net/c/1b704b27beb1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help