# Re: \[Patch net-next 02/13\] ipv4: introduce tracepoint trace\_ip\_queue\_xmit()

- From: Cong Wang \<hidden\>
- Date: 2021-08-12 00:37:51 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/08/7776460
- Thread: https://ratatoskr.run/netdev/2021/08/11208686/t.md

```text
On Wed, Aug 11, 2021 at 4:08 PM Martin KaFai Lau [ref] wrote:
> Some of the function names are hardly changed.

This is obviously wrong for two reasons:

1. Kernel developers did change them. As a quick example,
tcp_retransmit_skb() has been changed, we do have reasons to only trace
__tcp_retransmit_skb() instead.

2. Even if kernel developers never did, compilers can do inline too. For
example, I see nothing to stop compiler to inline tcp_transmit_skb()
which is static and only calls __tcp_transmit_skb(). You explicitly
mark bpf_fentry_test1() as noinline, don't you?

I understand you are eager to promote ebpf, however, please keep
reasonable on facts.

Thanks.
```