[PATCH net-next] net: w5100: check return value after calling platform_get_resource()

Subsystems: networking drivers, the rest

STALE1799d

2 messages, 2 authors, 2021-08-31 · open the first message on its own page

[PATCH net-next] net: w5100: check return value after calling platform_get_resource()

From: Yang Yingliang <hidden>
Date: 2021-08-31 08:35:16

It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/wiznet/w5100.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c
index 811815f8cd3b..f974e70a82e8 100644
--- a/drivers/net/ethernet/wiznet/w5100.c
+++ b/drivers/net/ethernet/wiznet/w5100.c
@@ -1047,6 +1047,8 @@ static int w5100_mmio_probe(struct platform_device *pdev)
 		mac_addr = data->mac_addr;
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!mem)
+		return -EINVAL;
 	if (resource_size(mem) < W5100_BUS_DIRECT_SIZE)
 		ops = &w5100_mmio_indirect_ops;
 	else
-- 
2.25.1

Re: [PATCH net-next] net: w5100: check return value after calling platform_get_resource()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-31 11:40:11

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 31 Aug 2021 16:40:18 +0800 you wrote:
It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/wiznet/w5100.c | 2 ++
 1 file changed, 2 insertions(+)
Here is the summary with links:
  - [net-next] net: w5100: check return value after calling platform_get_resource()
    https://git.kernel.org/netdev/net-next/c/a39ff4a47f3e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help