[PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

Subsystems: cxgb4 ethernet driver (cxgb4), networking drivers, the rest

STALE1809d

3 messages, 3 authors, 2021-08-26 · open the first message on its own page

[PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

From: Colin King <hidden>
Date: 2021-08-26 12:01:12

From: Colin Ian King <redacted>

There are spelling mistakes in dev_err and dev_info messages. Fix them.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
index 163efab27e9b..5060d3998889 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
@@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
 				write_unlock_bh(&ctbl->lock);
 				dev_err(adap->pdev_dev,
 					"CLIP FW cmd failed with error %d, "
-					"Connections using %pI6c wont be "
+					"Connections using %pI6c won't be "
 					"offloaded",
 					ret, ce->addr6.sin6_addr.s6_addr);
 				return ret;
@@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
 	} else {
 		write_unlock_bh(&ctbl->lock);
 		dev_info(adap->pdev_dev, "CLIP table overflow, "
-			 "Connections using %pI6c wont be offloaded",
+			 "Connections using %pI6c won't be offloaded",
 			 (void *)lip);
 		return -ENOMEM;
 	}
-- 
2.32.0

Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

From: Joe Perches <joe@perches.com>
Date: 2021-08-26 14:50:24

On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
From: Colin Ian King <redacted>

There are spelling mistakes in dev_err and dev_info messages. Fix them.
[]
quoted hunk
diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
[]
quoted hunk
@@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
 				write_unlock_bh(&ctbl->lock);
 1 file changed, 2 insertions(+), 2 deletions(-)
 				dev_err(adap->pdev_dev,
 					"CLIP FW cmd failed with error %d, "
-					"Connections using %pI6c wont be "
+					"Connections using %pI6c won't be "
 					"offloaded",
 					ret, ce->addr6.sin6_addr.s6_addr);
 				return ret;
@@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const u32 *lip, u8 v6)
 	} else {
 		write_unlock_bh(&ctbl->lock);
 		dev_info(adap->pdev_dev, "CLIP table overflow, "
-			 "Connections using %pI6c wont be offloaded",
+			 "Connections using %pI6c won't be offloaded",
 			 (void *)lip);
This is an unnecessary cast.
And these could coalesce the format fragments and add newlines too.

Re: [PATCH] cxgb4: clip_tbl: Fix spelling mistake "wont" -> "won't"

From: Denis Kirjanov <hidden>
Date: 2021-08-26 15:19:30

On 8/26/21, Joe Perches [off-list ref] wrote:
On Thu, 2021-08-26 at 13:01 +0100, Colin King wrote:
quoted
From: Colin Ian King <redacted>

There are spelling mistakes in dev_err and dev_info messages. Fix them.
[]
quoted
diff --git a/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
b/drivers/net/ethernet/chelsio/cxgb4/clip_tbl.c
[]
quoted
@@ -120,7 +120,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
u32 *lip, u8 v6)
 				write_unlock_bh(&ctbl->lock);
 1 file changed, 2 insertions(+), 2 deletions(-)
 				dev_err(adap->pdev_dev,
 					"CLIP FW cmd failed with error %d, "
-					"Connections using %pI6c wont be "
+					"Connections using %pI6c won't be "
 					"offloaded",
 					ret, ce->addr6.sin6_addr.s6_addr);
 				return ret;
@@ -133,7 +133,7 @@ int cxgb4_clip_get(const struct net_device *dev, const
u32 *lip, u8 v6)
 	} else {
 		write_unlock_bh(&ctbl->lock);
 		dev_info(adap->pdev_dev, "CLIP table overflow, "
-			 "Connections using %pI6c wont be offloaded",
+			 "Connections using %pI6c won't be offloaded",
 			 (void *)lip);
This is an unnecessary cast.
And these could coalesce the format fragments and add newlines too.
and fix the leftover in the comment:
./t4_hw.c:7185:	 * set wont be sent when we are flashing FW.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help