[PATCH -next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg()

Subsystems: marvell octeontx2 physical function driver, networking drivers, the rest

STALE1831d

2 messages, 2 authors, 2021-08-26 · open the first message on its own page

[PATCH -next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg()

From: Yang Yingliang <hidden>
Date: 2021-08-25 06:29:16

If otx2_mbox_get_rsp() fails, otx2_set_flowkey_cfg() need return an
error code.

Fixes: e7938365459f ("octeontx2-pf: Fix algorithm index in MCAM rules with RSS action")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
index f630e5713025..ad79d2c05ca4 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
@@ -289,8 +289,10 @@ int otx2_set_flowkey_cfg(struct otx2_nic *pfvf)
 
 	rsp = (struct nix_rss_flowkey_cfg_rsp *)
 			otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
-	if (IS_ERR(rsp))
+	if (IS_ERR(rsp)) {
+		err = PTR_ERR(rsp);
 		goto fail;
+	}
 
 	pfvf->hw.flowkey_alg_idx = rsp->alg_idx;
 fail:
-- 
2.25.1

Re: [PATCH -next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg()

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-26 09:50:11

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 25 Aug 2021 14:34:47 +0800 you wrote:
If otx2_mbox_get_rsp() fails, otx2_set_flowkey_cfg() need return an
error code.

Fixes: e7938365459f ("octeontx2-pf: Fix algorithm index in MCAM rules with RSS action")
Reported-by: Hulk Robot <redacted>
Signed-off-by: Yang Yingliang <redacted>

[...]
Here is the summary with links:
  - [-next] octeontx2-pf: cn10k: Fix error return code in otx2_set_flowkey_cfg()
    https://git.kernel.org/netdev/net-next/c/5e8243e66b4d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help