[PATCH net-next v3] page_pool: use relaxed atomic for release side accounting

Subsystems: networking [general], page pool, the rest

STALE1818d REVIEWED: 1 (0M)

1 review trailer.

4 messages, 3 authors, 2021-08-24 · open the first message on its own page

[PATCH net-next v3] page_pool: use relaxed atomic for release side accounting

From: Yunsheng Lin <hidden>
Date: 2021-08-24 09:08:07

There is no need to synchronize the account updating, so
use the relaxed atomic to avoid some memory barrier in the
data path.

Acked-by: Jesper Dangaard Brouer <redacted>
Signed-off-by: Yunsheng Lin <redacted>
---
V3: Drop patch 2.
V2: Remove unnecessary unliky() mark as pointed out by
    Heiner.
---
 net/core/page_pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index e140905..1a69784 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -370,7 +370,7 @@ void page_pool_release_page(struct page_pool *pool, struct page *page)
 	/* This may be the last page returned, releasing the pool, so
 	 * it is not safe to reference pool afterwards.
 	 */
-	count = atomic_inc_return(&pool->pages_state_release_cnt);
+	count = atomic_inc_return_relaxed(&pool->pages_state_release_cnt);
 	trace_page_pool_state_release(pool, page, count);
 }
 EXPORT_SYMBOL(page_pool_release_page);
-- 
2.7.4

Re: [PATCH net-next v3] page_pool: use relaxed atomic for release side accounting

From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: 2021-08-24 09:13:01

On Tue, 24 Aug 2021 at 12:07, Yunsheng Lin [off-list ref] wrote:
quoted hunk
There is no need to synchronize the account updating, so
use the relaxed atomic to avoid some memory barrier in the
data path.

Acked-by: Jesper Dangaard Brouer <redacted>
Signed-off-by: Yunsheng Lin <redacted>
---
V3: Drop patch 2.
V2: Remove unnecessary unliky() mark as pointed out by
    Heiner.
---
 net/core/page_pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index e140905..1a69784 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -370,7 +370,7 @@ void page_pool_release_page(struct page_pool *pool, struct page *page)
        /* This may be the last page returned, releasing the pool, so
         * it is not safe to reference pool afterwards.
         */
-       count = atomic_inc_return(&pool->pages_state_release_cnt);
+       count = atomic_inc_return_relaxed(&pool->pages_state_release_cnt);
        trace_page_pool_state_release(pool, page, count);
 }
 EXPORT_SYMBOL(page_pool_release_page);
--
2.7.4

Re: [PATCH net-next v3] page_pool: use relaxed atomic for release side accounting

From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Date: 2021-08-24 09:13:36

On Tue, 24 Aug 2021 at 12:07, Yunsheng Lin [off-list ref] wrote:
quoted hunk
There is no need to synchronize the account updating, so
use the relaxed atomic to avoid some memory barrier in the
data path.

Acked-by: Jesper Dangaard Brouer <redacted>
Signed-off-by: Yunsheng Lin <redacted>
---
V3: Drop patch 2.
V2: Remove unnecessary unliky() mark as pointed out by
    Heiner.
---
 net/core/page_pool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/page_pool.c b/net/core/page_pool.c
index e140905..1a69784 100644
--- a/net/core/page_pool.c
+++ b/net/core/page_pool.c
@@ -370,7 +370,7 @@ void page_pool_release_page(struct page_pool *pool, struct page *page)
        /* This may be the last page returned, releasing the pool, so
         * it is not safe to reference pool afterwards.
         */
-       count = atomic_inc_return(&pool->pages_state_release_cnt);
+       count = atomic_inc_return_relaxed(&pool->pages_state_release_cnt);
        trace_page_pool_state_release(pool, page, count);
 }
 EXPORT_SYMBOL(page_pool_release_page);
--
2.7.4
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

Re: [PATCH net-next v3] page_pool: use relaxed atomic for release side accounting

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-24 09:50:12

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 24 Aug 2021 17:06:49 +0800 you wrote:
There is no need to synchronize the account updating, so
use the relaxed atomic to avoid some memory barrier in the
data path.

Acked-by: Jesper Dangaard Brouer <redacted>
Signed-off-by: Yunsheng Lin <redacted>

[...]
Here is the summary with links:
  - [net-next,v3] page_pool: use relaxed atomic for release side accounting
    https://git.kernel.org/netdev/net-next/c/7fb9b66dc9ce

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help