[PATCH] ath11k: qmi: avoid error messages when dma allocation fails

Subsystems: atheros ath generic utilities, qualcomm atheros ath11k wireless driver, the rest

STALE1801d LANDED

Landed in mainline as b9b5948cdd7b on 2021-09-28.

2 messages, 2 authors, 2021-09-28 · open the first message on its own page

[PATCH] ath11k: qmi: avoid error messages when dma allocation fails

From: Aaron Ma <hidden>
Date: 2021-08-23 06:33:18

qmi tries to allocate a large contiguous dma memory at first,
on the AMD Ryzen platform it fails, then retries with small slices.
So set flag GFP_NOWARN to avoid flooding dmesg.

Signed-off-by: Aaron Ma <redacted>
---
 drivers/net/wireless/ath/ath11k/qmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c
index b5e34d670715..d6270e96d46c 100644
--- a/drivers/net/wireless/ath/ath11k/qmi.c
+++ b/drivers/net/wireless/ath/ath11k/qmi.c
@@ -1770,7 +1770,7 @@ static int ath11k_qmi_alloc_target_mem_chunk(struct ath11k_base *ab)
 		chunk->vaddr = dma_alloc_coherent(ab->dev,
 						  chunk->size,
 						  &chunk->paddr,
-						  GFP_KERNEL);
+						  GFP_KERNEL | __GFP_NOWARN);
 		if (!chunk->vaddr) {
 			if (ab->qmi.mem_seg_count <= ATH11K_QMI_FW_MEM_REQ_SEGMENT_CNT) {
 				ath11k_dbg(ab, ATH11K_DBG_QMI,
-- 
2.30.2

Re: [PATCH] ath11k: qmi: avoid error messages when dma allocation fails

From: Kalle Valo <hidden>
Date: 2021-09-28 10:55:33

Aaron Ma [off-list ref] wrote:
qmi tries to allocate a large contiguous dma memory at first,
on the AMD Ryzen platform it fails, then retries with small slices.
So set flag GFP_NOWARN to avoid flooding dmesg.

Signed-off-by: Aaron Ma <redacted>
Signed-off-by: Kalle Valo <redacted>
Patch applied to ath-next branch of ath.git, thanks.

b9b5948cdd7b ath11k: qmi: avoid error messages when dma allocation fails

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20210823063258.37747-1-aaron.ma@canonical.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help