[PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks

Subsystems: ethernet phy library, networking drivers, the rest

STALE1814d LANDED

Landed in mainline as 93100d6817b0 on 2021-08-24.

3 messages, 3 authors, 2021-08-24 · open the first message on its own page

[PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks

From: DENG Qingfang <dqfext@gmail.com>
Date: 2021-08-23 04:44:43

Without suspend/resume callbacks, the PHY cannot be powered down/up
administratively.

Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
---
 drivers/net/phy/mediatek-ge.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c
index 11ff335d6228..b7a5ae20edd5 100644
--- a/drivers/net/phy/mediatek-ge.c
+++ b/drivers/net/phy/mediatek-ge.c
@@ -81,6 +81,8 @@ static struct phy_driver mtk_gephy_driver[] = {
 		 */
 		.config_intr	= genphy_no_config_intr,
 		.handle_interrupt = genphy_handle_interrupt_no_ack,
+		.suspend	= genphy_suspend,
+		.resume		= genphy_resume,
 		.read_page	= mtk_gephy_read_page,
 		.write_page	= mtk_gephy_write_page,
 	},
@@ -93,6 +95,8 @@ static struct phy_driver mtk_gephy_driver[] = {
 		 */
 		.config_intr	= genphy_no_config_intr,
 		.handle_interrupt = genphy_handle_interrupt_no_ack,
+		.suspend	= genphy_suspend,
+		.resume		= genphy_resume,
 		.read_page	= mtk_gephy_read_page,
 		.write_page	= mtk_gephy_write_page,
 	},
-- 
2.25.1

Re: [PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks

From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-08-23 13:00:32

On Mon, Aug 23, 2021 at 12:44:21PM +0800, DENG Qingfang wrote:
Without suspend/resume callbacks, the PHY cannot be powered down/up
administratively.

Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net] net: phy: mediatek: add the missing suspend/resume callbacks

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-08-24 23:53:33

On Mon, 23 Aug 2021 15:00:08 +0200 Andrew Lunn wrote:
On Mon, Aug 23, 2021 at 12:44:21PM +0800, DENG Qingfang wrote:
quoted
Without suspend/resume callbacks, the PHY cannot be powered down/up
administratively.

Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>  
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help