[PATCH] ipv6: correct comments about fib6_node sernum

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE1814d

3 messages, 3 authors, 2021-08-24 · open the first message on its own page

[PATCH] ipv6: correct comments about fib6_node sernum

From: zhang kai <hidden>
Date: 2021-08-23 04:21:13

correct comments in set and get fn_sernum

Signed-off-by: zhang kai <redacted>
---
 include/net/ip6_fib.h | 4 ++--
 net/ipv6/ip6_fib.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
index 15b7fbe6b..c412dde4d 100644
--- a/include/net/ip6_fib.h
+++ b/include/net/ip6_fib.h
@@ -267,7 +267,7 @@ static inline bool fib6_check_expired(const struct fib6_info *f6i)
 	return false;
 }
 
-/* Function to safely get fn->sernum for passed in rt
+/* Function to safely get fn->fn_sernum for passed in rt
  * and store result in passed in cookie.
  * Return true if we can get cookie safely
  * Return false if not
@@ -282,7 +282,7 @@ static inline bool fib6_get_cookie_safe(const struct fib6_info *f6i,
 
 	if (fn) {
 		*cookie = fn->fn_sernum;
-		/* pairs with smp_wmb() in fib6_update_sernum_upto_root() */
+		/* pairs with smp_wmb() in __fib6_update_sernum_upto_root() */
 		smp_rmb();
 		status = true;
 	}
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 679699e95..4d7b93baa 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -1340,7 +1340,7 @@ static void __fib6_update_sernum_upto_root(struct fib6_info *rt,
 	struct fib6_node *fn = rcu_dereference_protected(rt->fib6_node,
 				lockdep_is_held(&rt->fib6_table->tb6_lock));
 
-	/* paired with smp_rmb() in rt6_get_cookie_safe() */
+	/* paired with smp_rmb() in fib6_get_cookie_safe() */
 	smp_wmb();
 	while (fn) {
 		fn->fn_sernum = sernum;
-- 
2.17.1

Re: [PATCH] ipv6: correct comments about fib6_node sernum

From: David Ahern <hidden>
Date: 2021-08-24 04:21:58

On 8/22/21 9:49 PM, zhang kai wrote:
correct comments in set and get fn_sernum

Signed-off-by: zhang kai <redacted>
---
 include/net/ip6_fib.h | 4 ++--
 net/ipv6/ip6_fib.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)


Reviewed-by: David Ahern <dsahern@kernel.org>

Re: [PATCH] ipv6: correct comments about fib6_node sernum

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-24 09:10:08

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Mon, 23 Aug 2021 11:49:00 +0800 you wrote:
correct comments in set and get fn_sernum

Signed-off-by: zhang kai <redacted>
---
 include/net/ip6_fib.h | 4 ++--
 net/ipv6/ip6_fib.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
  - ipv6: correct comments about fib6_node sernum
    https://git.kernel.org/netdev/net/c/446e7f218b76

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help