# Re: \[PATCH v2 22/63\] HID: cp2112: Use struct\_group() for memcpy() region

- From: Jiri Kosina \<jikos@kernel.org\>
- Date: 2021-08-20 13:01:52 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/08/1483946
- Thread: https://ratatoskr.run/linux-input/2021/08/1481256/t.md

```text
On Tue, 17 Aug 2021, Kees Cook wrote:

> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring fields.
> 
> Use struct_group() in struct cp2112_string_report around members report,
> length, type, and string, so they can be referenced together. This will
> allow memcpy() and sizeof() to more easily reason about sizes, improve
> readability, and avoid future warnings about writing beyond the end of
> report.
> 
> "pahole" shows no size nor member offset changes to struct
> cp2112_string_report.  "objdump -d" shows no meaningful object
> code changes (i.e. only source line number induced differences.)
> 
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: Benjamin Tissoires <redacted>
> Cc: <redacted>
> Signed-off-by: Kees Cook <redacted>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

```
