[PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI

Subsystems: networking drivers, ptp hardware clock support, the rest

STALE1814d

3 messages, 3 authors, 2021-08-16 · open the first message on its own page

[PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-08-13 17:33:37

During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH
incidentally dropped the implicit dependency on the PCI. Restore it.

Fixes: 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")
Reported-by: kernel test robot <redacted>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/ptp/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 8c20e524e9ad..e085c255da0c 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -90,7 +90,8 @@ config PTP_1588_CLOCK_INES
 config PTP_1588_CLOCK_PCH
 	tristate "Intel PCH EG20T as PTP clock"
 	depends on X86_32 || COMPILE_TEST
-	depends on HAS_IOMEM && NET
+	depends on HAS_IOMEM && PCI
+	depends on NET
 	imply PTP_1588_CLOCK
 	help
 	  This driver adds support for using the PCH EG20T as a PTP
-- 
2.30.2

Re: [PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-08-13 21:34:18

On Fri, 13 Aug 2021 20:33:27 +0300 Andy Shevchenko wrote:
During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH
incidentally dropped the implicit dependency on the PCI. Restore it.

Fixes: 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")
It was breaking build for 9 years and nobody hit it? 
What's the build failure?

Re: [PATCH v1 net 1/1] ptp_pch: Restore dependency on PCI

From: patchwork-bot+netdevbpf@kernel.org
Date: 2021-08-16 10:30:11

Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Fri, 13 Aug 2021 20:33:27 +0300 you wrote:
During the swap dependency on PCH_GBE to selection PTP_1588_CLOCK_PCH
incidentally dropped the implicit dependency on the PCI. Restore it.

Fixes: 18d359ceb044 ("pch_gbe, ptp_pch: Fix the dependency direction between these drivers")
Reported-by: kernel test robot <redacted>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

[...]
Here is the summary with links:
  - [v1,net,1/1] ptp_pch: Restore dependency on PCI
    https://git.kernel.org/netdev/net/c/55c8fca1dae1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help