Dear David, dear Jakub,
The script ./scripts/checkkconfigsymbols.py warns on invalid references to
Kconfig symbols (often, minor typos, name confusions or outdated references).
This patch series addresses all issues reported by
./scripts/checkkconfigsymbols.py in ./net/ and ./drivers/net/ for Kconfig
and Makefile files. Issues in the Kconfig and Makefile files indicate some
shortcomings in the overall build definitions, and often are true actionable
issues to address.
These issues can be identified and filtered by:
./scripts/checkkconfigsymbols.py \
| grep -E "(drivers/)?net/.*(Kconfig|Makefile)" -B 1 -A 1
After applying this patch series on linux-next (next-20210811), the command
above yields no further issues to address.
Please pick this patch series into your net-next tree.
Best regards,
Lukas
Lukas Bulwahn (3):
net: Kconfig: remove obsolete reference to config MICROBLAZE_64K_PAGES
net: 802: remove dead leftover after ipx driver removal
net: dpaa_eth: remove dead select in menuconfig FSL_DPAA_ETH
drivers/net/Kconfig | 4 +-
drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
net/802/Makefile | 1 -
net/802/p8023.c | 60 ---------------------
4 files changed, 2 insertions(+), 64 deletions(-)
delete mode 100644 net/802/p8023.c
--
2.17.1
Commit 05cdf457477d ("microblaze: Remove noMMU code") removes config
MICROBLAZE_64K_PAGES in arch/microblaze/Kconfig. However, there is still
a reference to MICROBLAZE_64K_PAGES in the config VMXNET3 in
./drivers/net/Kconfig.
Remove this obsolete reference to config MICROBLAZE_64K_PAGES.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/net/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Commit 7a2e838d28cf ("staging: ipx: delete it from the tree") removes the
ipx driver and the config IPX. Since then, there is some dead leftover in
./net/802/, that was once used by the IPX driver, but has no other user.
Remove this dead leftover.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
net/802/Makefile | 1 -
net/802/p8023.c | 60 ------------------------------------------------
2 files changed, 61 deletions(-)
delete mode 100644 net/802/p8023.c
@@ -1,60 +0,0 @@-// SPDX-License-Identifier: GPL-2.0-or-later-/*- * NET3: 802.3 data link hooks used for IPX 802.3- *- * 802.3 isn't really a protocol data link layer. Some old IPX stuff- * uses it however. Note that there is only one 802.3 protocol layer- * in the system. We don't currently support different protocols- * running raw 802.3 on different devices. Thankfully nobody else- * has done anything like the old IPX.- */--#include <linux/in.h>-#include <linux/mm.h>-#include <linux/module.h>-#include <linux/netdevice.h>-#include <linux/skbuff.h>-#include <linux/slab.h>--#include <net/datalink.h>-#include <net/p8022.h>--/*- * Place an 802.3 header on a packet. The driver will do the mac- * addresses, we just need to give it the buffer length.- */-static int p8023_request(struct datalink_proto *dl,- struct sk_buff *skb, unsigned char *dest_node)-{- struct net_device *dev = skb->dev;-- dev_hard_header(skb, dev, ETH_P_802_3, dest_node, NULL, skb->len);- return dev_queue_xmit(skb);-}--/*- * Create an 802.3 client. Note there can be only one 802.3 client- */-struct datalink_proto *make_8023_client(void)-{- struct datalink_proto *proto = kmalloc(sizeof(*proto), GFP_ATOMIC);-- if (proto) {- proto->header_length = 0;- proto->request = p8023_request;- }- return proto;-}--/*- * Destroy the 802.3 client.- */-void destroy_8023_client(struct datalink_proto *dl)-{- kfree(dl);-}--EXPORT_SYMBOL(destroy_8023_client);-EXPORT_SYMBOL(make_8023_client);--MODULE_LICENSE("GPL");
The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
FSL_FMAN_MAC never existed in the kernel tree.
Hence, ./scripts/checkkconfigsymbols.py warns:
FSL_FMAN_MAC
Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig
Remove this dead select in menuconfig FSL_DPAA_ETH.
Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
1 file changed, 1 deletion(-)
-----Original Message-----
From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Sent: 12 August 2021 11:38
To: David S . Miller <davem@davemloft.net>; Jakub Kicinski
[off-list ref]; netdev@vger.kernel.org
Cc: Madalin Bucur <madalin.bucur@nxp.com>; Randy Dunlap
[off-list ref]; kernel-janitors@vger.kernel.org; linux-
kernel@vger.kernel.org; Lukas Bulwahn [off-list ref]
Subject: [PATCH 3/3] net: dpaa_eth: remove dead select in menuconfig
FSL_DPAA_ETH
The menuconfig FSL_DPAA_ETH selects config FSL_FMAN_MAC, but the config
FSL_FMAN_MAC never existed in the kernel tree.
Hence, ./scripts/checkkconfigsymbols.py warns:
FSL_FMAN_MAC
Referencing files: drivers/net/ethernet/freescale/dpaa/Kconfig
Remove this dead select in menuconfig FSL_DPAA_ETH.
Fixes: 9ad1a3749333 ("dpaa_eth: add support for DPAA Ethernet")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
drivers/net/ethernet/freescale/dpaa/Kconfig | 1 -
1 file changed, 1 deletion(-)
From: Jakub Kicinski <kuba@kernel.org> Date: 2021-08-13 23:34:11
On Thu, 12 Aug 2021 10:38:03 +0200 Lukas Bulwahn wrote:
The script ./scripts/checkkconfigsymbols.py warns on invalid references to
Kconfig symbols (often, minor typos, name confusions or outdated references).
This patch series addresses all issues reported by
./scripts/checkkconfigsymbols.py in ./net/ and ./drivers/net/ for Kconfig
and Makefile files. Issues in the Kconfig and Makefile files indicate some
shortcomings in the overall build definitions, and often are true actionable
issues to address.
These issues can be identified and filtered by:
./scripts/checkkconfigsymbols.py \
| grep -E "(drivers/)?net/.*(Kconfig|Makefile)" -B 1 -A 1
After applying this patch series on linux-next (next-20210811), the command
above yields no further issues to address.
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 12 Aug 2021 10:38:03 +0200 you wrote:
Dear David, dear Jakub,
The script ./scripts/checkkconfigsymbols.py warns on invalid references to
Kconfig symbols (often, minor typos, name confusions or outdated references).
This patch series addresses all issues reported by
./scripts/checkkconfigsymbols.py in ./net/ and ./drivers/net/ for Kconfig
and Makefile files. Issues in the Kconfig and Makefile files indicate some
shortcomings in the overall build definitions, and often are true actionable
issues to address.
[...]