[PATCH] atm: horizon: Fix spelling mistakes in TX comment

Subsystems: atm, the rest

STALE1823d

3 messages, 2 authors, 2021-08-07 · open the first message on its own page

[PATCH] atm: horizon: Fix spelling mistakes in TX comment

From: Jun Miao <hidden>
Date: 2021-08-07 12:58:50

It's "mustn't", not "musn't", meaning "shall not".
Let's fix that.

Signed-off-by: Jun Miao <redacted>
---
 drivers/atm/horizon.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
index 4f2951cbe69c..9ee494bc5c51 100644
--- a/drivers/atm/horizon.c
+++ b/drivers/atm/horizon.c
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
   
   // Part of the job is done by atm_pcr_goal which gives us a PCR
   // specification which says: EITHER grab the maximum available PCR
-  // (and perhaps a lower bound which we musn't pass), OR grab this
+  // (and perhaps a lower bound which we mustn't pass), OR grab this
   // amount, rounding down if you have to (and perhaps a lower bound
-  // which we musn't pass) OR grab this amount, rounding up if you
-  // have to (and perhaps an upper bound which we musn't pass). If any
+  // which we mustn't pass) OR grab this amount, rounding up if you
+  // have to (and perhaps an upper bound which we mustn't pass). If any
   // bounds ARE passed we fail. Note that rounding is only rounding to
   // match device limitations, we do not round down to satisfy
   // bandwidth availability even if this would not violate any given
-- 
2.32.0

Re: [PATCH] atm: horizon: Fix spelling mistakes in TX comment

From: Joe Perches <joe@perches.com>
Date: 2021-08-07 13:22:01

On Sat, 2021-08-07 at 20:49 +0800, Jun Miao wrote:
It's "mustn't", not "musn't", meaning "shall not".
Let's fix that.
Perhaps more useful to change to 'must not' for the
non-native speaker.
 
quoted hunk
diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
[]
quoted hunk
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)
   

   // Part of the job is done by atm_pcr_goal which gives us a PCR
   // specification which says: EITHER grab the maximum available PCR
-  // (and perhaps a lower bound which we musn't pass), OR grab this
+  // (and perhaps a lower bound which we mustn't pass), OR grab this
   // amount, rounding down if you have to (and perhaps a lower bound
-  // which we musn't pass) OR grab this amount, rounding up if you
-  // have to (and perhaps an upper bound which we musn't pass). If any
+  // which we mustn't pass) OR grab this amount, rounding up if you
+  // have to (and perhaps an upper bound which we mustn't pass). If any
   // bounds ARE passed we fail. Note that rounding is only rounding to
   // match device limitations, we do not round down to satisfy
   // bandwidth availability even if this would not violate any given

Re: [PATCH] atm: horizon: Fix spelling mistakes in TX comment

From: Jun Miao <hidden>
Date: 2021-08-07 13:57:34

On 8/7/21 9:21 PM, Joe Perches wrote:
[Please note: This e-mail is from an EXTERNAL e-mail address]

On Sat, 2021-08-07 at 20:49 +0800, Jun Miao wrote:
quoted
It's "mustn't", not "musn't", meaning "shall not".
Let's fix that.
Perhaps more useful to change to 'must not' for the
non-native speaker.
Ok, V2 : Suggested-by: Joe Perches [off-list ref]

Thanks
Jun
quoted
diff --git a/drivers/atm/horizon.c b/drivers/atm/horizon.c
[]
What's mean this [] ?

quoted
@@ -2167,10 +2167,10 @@ static int hrz_open (struct atm_vcc *atm_vcc)


    // Part of the job is done by atm_pcr_goal which gives us a PCR
    // specification which says: EITHER grab the maximum available PCR
-  // (and perhaps a lower bound which we musn't pass), OR grab this
+  // (and perhaps a lower bound which we mustn't pass), OR grab this
    // amount, rounding down if you have to (and perhaps a lower bound
-  // which we musn't pass) OR grab this amount, rounding up if you
-  // have to (and perhaps an upper bound which we musn't pass). If any
+  // which we mustn't pass) OR grab this amount, rounding up if you
+  // have to (and perhaps an upper bound which we mustn't pass). If any
    // bounds ARE passed we fail. Note that rounding is only rounding to
    // match device limitations, we do not round down to satisfy
    // bandwidth availability even if this would not violate any given
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help