# Re: \[PATCH net-next 2/5 v2\] net: dsa: rtl8366: Drop custom VLAN set-up

- From: Florian Fainelli \<f.fainelli@gmail.com\>
- Date: 2021-08-31 01:02:13 
- List: netdev
- Page: https://ratatoskr.run/netdev/2021/08/11210559
- Thread: https://ratatoskr.run/netdev/2021/08/11210521/t.md

```text


On 8/30/2021 2:48 PM, Linus Walleij wrote:
> This hacky default VLAN setup was done in order to direct
> packets to the right ports and provide port isolation, both
> which we now support properly using custom tags and proper
> bridge port isolation.
>
> We can drop the custom VLAN code and leave all VLAN handling
> alone, as users expect things to be. We can also drop
> ds->configure_vlan_while_not_filtering = false; and let
> the core deal with any VLANs it wants.
>
> Cc: Vladimir Oltean <olteanv@gmail.com>
> Cc: Alvin Šipraga <redacted>
> Cc: Mauri Sandberg <redacted>
> Cc: DENG Qingfang <dqfext@gmail.com>
> Signed-off-by: Linus Walleij <redacted>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian
```