[PATCH] qrtr: mhi: Fix duplicate channel start

Subsystems: networking [general], qualcomm ipc router (qrtr) driver, the rest

STALE1813d

2 messages, 2 authors, 2021-08-26 · open the first message on its own page

[PATCH] qrtr: mhi: Fix duplicate channel start

From: Loic Poulain <hidden>
Date: 2021-08-26 15:25:17

commit ce78ffa3ef16 ("net: really fix the build...") handling a merge
conflict causes the mhi_prepare_for_transfer() function to be called
twice (with different flags), leading to QRTR probing issues.

Fixes: ce78ffa3ef16 ("net: really fix the build...")
Signed-off-by: Loic Poulain <redacted>
---
 net/qrtr/mhi.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/net/qrtr/mhi.c b/net/qrtr/mhi.c
index 1dc955c..deb8b03 100644
--- a/net/qrtr/mhi.c
+++ b/net/qrtr/mhi.c
@@ -83,11 +83,6 @@ static int qcom_mhi_qrtr_probe(struct mhi_device *mhi_dev,
 	struct qrtr_mhi_dev *qdev;
 	int rc;
 
-	/* start channels */
-	rc = mhi_prepare_for_transfer(mhi_dev, 0);
-	if (rc)
-		return rc;
-
 	qdev = devm_kzalloc(&mhi_dev->dev, sizeof(*qdev), GFP_KERNEL);
 	if (!qdev)
 		return -ENOMEM;
-- 
2.7.4

Re: [PATCH] qrtr: mhi: Fix duplicate channel start

From: Kalle Valo <hidden>
Date: 2021-08-26 16:34:44

Loic Poulain [off-list ref] writes:
commit ce78ffa3ef16 ("net: really fix the build...") handling a merge
conflict causes the mhi_prepare_for_transfer() function to be called
twice (with different flags), leading to QRTR probing issues.

Fixes: ce78ffa3ef16 ("net: really fix the build...")
Signed-off-by: Loic Poulain <redacted>
Thanks for the patch, but with this patch the whole kernel crashes. I
tested on a NUC box with QCA6390 using v5.14-rc7. Unfortunately no
netconsole at the moment as I'm moving my workstations.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help