[External] [PATCH] ovs: datapath: clear skb->tstamp in forwarding path

fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
doesn't clear skb->tstamp. We encountered a problem with linux
version 5.4.56 and ovs version 2.14.1, and packets failed to
dequeue from qdisc when fq qdisc was attached to ovs port.

Signed-off-by: kaixi.fan <redacted>
Signed-off-by: xiexiaohui <redacted>
Reviewed-by: Cong Wang <redacted>
---
 net/openvswitch/vport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 88deb5b41429..cf2ce5812489 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c

@@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct

sk_buff *skb, u8 mac_proto)
  }

  skb->dev = vport->dev;
+ skb->tstamp = 0;
  vport->ops->send(skb);
  return;

-- 
2.20.1

On Tue, 17 Aug 2021 10:25:24 +0800 范开喜 wrote:

This patch has been mangled by your email client, please try
git send-email if possible.

Jakub Kicinski [off-list ref] 于2021年8月17日周二 下午9:36写道：

On Tue, 17 Aug 2021 10:25:24 +0800 范开喜 wrote:

quoted

fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
doesn't clear skb->tstamp. We encountered a problem with linux
version 5.4.56 and ovs version 2.14.1, and packets failed to
dequeue from qdisc when fq qdisc was attached to ovs port.

Signed-off-by: kaixi.fan <redacted>
Signed-off-by: xiexiaohui <redacted>
Reviewed-by: Cong Wang <redacted>
---
 net/openvswitch/vport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 88deb5b41429..cf2ce5812489 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c

@@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct

sk_buff *skb, u8 mac_proto)
  }

  skb->dev = vport->dev;
+ skb->tstamp = 0;
  vport->ops->send(skb);
  return;

This patch has been mangled by your email client, please try
git send-email if possible.

Sorry. I resend it through git send-email. Thanks.